DPDK patches and discussions
 help / color / mirror / Atom feed
From: nickcooper-zhangtonghao <nic@opencloud.tech>
To: Yong Wang <yongwang@vmware.com>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 1/4] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup.
Date: Wed, 18 Jan 2017 10:41:48 +0800	[thread overview]
Message-ID: <72AA715B-7728-446E-BEE0-DA63EF0DFA60@opencloud.tech> (raw)
In-Reply-To: <BY2PR05MB235953D3D13114C9CD89C3FCAF7F0@BY2PR05MB2359.namprd05.prod.outlook.com>



> On Jan 18, 2017, at 10:05 AM, Yong Wang <yongwang@vmware.com> wrote:
> 
> Any downside with free/reallocation now that memzone can be freed?  Allocation with max ring size should work but is kind of wasteful in terms of memory usage and I assume this type of ring size change should not be a frequent operation.


Not free/realloc them anymore. I guess it is necessary to use the
allocation with max ring size. The seg fault really bother us.
and the app (e.g. ovs) may change it frequently when tuning performance.

      reply	other threads:[~2017-01-18  2:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09  2:59 Nick Zhang
2017-01-09  2:59 ` [dpdk-dev] [PATCH v3 2/4] vmxnet3: Avoid segfault caused by vmxnet3_dev_rx_queue_setup Nick Zhang
2017-01-09  2:59 ` [dpdk-dev] [PATCH v3 3/4] vmxnet3: Avoid memory leak in vmxnet3_dev_tx_queue_setup Nick Zhang
2017-01-09  2:59 ` [dpdk-dev] [PATCH v3 4/4] vmxnet3: Avoid segfault caused by vmxnet3_dev_tx_queue_setup Nick Zhang
2017-01-17 20:15 ` [dpdk-dev] [PATCH v3 1/4] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup Yong Wang
2017-01-18  1:37   ` nickcooper-zhangtonghao
2017-01-18  2:05     ` Yong Wang
2017-01-18  2:41       ` nickcooper-zhangtonghao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72AA715B-7728-446E-BEE0-DA63EF0DFA60@opencloud.tech \
    --to=nic@opencloud.tech \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=yongwang@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).