From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Jie Hai <haijie1@huawei.com>,
dev@dpdk.org, Yisen Zhuang <yisen.zhuang@huawei.com>
Cc: lihuisong@huawei.com, fengchengwen@huawei.com, liudongdong3@huawei.com
Subject: Re: [PATCH] net/hns3: support new device
Date: Wed, 6 Mar 2024 10:00:05 +0000 [thread overview]
Message-ID: <72d40b88-0729-4aae-9fb5-fa84fb12ad79@amd.com> (raw)
In-Reply-To: <20240306092112.506493-1-haijie1@huawei.com>
On 3/6/2024 9:21 AM, Jie Hai wrote:
> This patch adds new device to the driver.
>
Just checking if a documentation update is rquired, hns3.rst has
following description, "network engine found in the HiSilicon Kunpeng
920 SoC and Kunpeng 930 SoC", is this still holds with new device support?
Also you may want to update release notes to announce the new device
support.
Can you please give some more details in the commit log about the new
supported device, and if possible provide product links etc..
You may also request to backport this change to LTS (by adding stable
tag), assuming LTS code already supports these new devices. LTS
maintainers can decide to pick or not pick the patch to LTS release.
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> ---
> drivers/net/hns3/hns3_cmd.c | 4 +++-
> drivers/net/hns3/hns3_ethdev.c | 2 ++
> drivers/net/hns3/hns3_ethdev.h | 2 ++
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/hns3/hns3_cmd.c b/drivers/net/hns3/hns3_cmd.c
> index 2c1664485bef..001ff49b368b 100644
> --- a/drivers/net/hns3/hns3_cmd.c
> +++ b/drivers/net/hns3/hns3_cmd.c
> @@ -545,7 +545,9 @@ hns3_set_dcb_capability(struct hns3_hw *hw)
> if (device_id == HNS3_DEV_ID_25GE_RDMA ||
> device_id == HNS3_DEV_ID_50GE_RDMA ||
> device_id == HNS3_DEV_ID_100G_RDMA_MACSEC ||
> - device_id == HNS3_DEV_ID_200G_RDMA)
> + device_id == HNS3_DEV_ID_200G_RDMA ||
> + device_id == HNS3_DEV_ID_100G_ROH ||
> + device_id == HNS3_DEV_ID_200G_ROH)
> hns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_DCB_B, 1);
> }
>
> diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
> index b10d1216d2d1..9730b9a7e9f6 100644
> --- a/drivers/net/hns3/hns3_ethdev.c
> +++ b/drivers/net/hns3/hns3_ethdev.c
> @@ -6649,6 +6649,8 @@ static const struct rte_pci_id pci_id_hns3_map[] = {
> { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_50GE_RDMA) },
> { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_100G_RDMA_MACSEC) },
> { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_200G_RDMA) },
> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_100G_ROH) },
> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_200G_ROH) },
> { .vendor_id = 0, }, /* sentinel */
> };
>
> diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h
> index 12d8299def39..e70c5fff2a45 100644
> --- a/drivers/net/hns3/hns3_ethdev.h
> +++ b/drivers/net/hns3/hns3_ethdev.h
> @@ -28,7 +28,9 @@
> #define HNS3_DEV_ID_25GE_RDMA 0xA222
> #define HNS3_DEV_ID_50GE_RDMA 0xA224
> #define HNS3_DEV_ID_100G_RDMA_MACSEC 0xA226
> +#define HNS3_DEV_ID_100G_ROH 0xA227
> #define HNS3_DEV_ID_200G_RDMA 0xA228
> +#define HNS3_DEV_ID_200G_ROH 0xA22C
> #define HNS3_DEV_ID_100G_VF 0xA22E
> #define HNS3_DEV_ID_100G_RDMA_PFC_VF 0xA22F
>
next prev parent reply other threads:[~2024-03-06 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 9:21 Jie Hai
2024-03-06 10:00 ` Ferruh Yigit [this message]
2024-03-08 9:28 ` Jie Hai
2024-03-15 2:54 ` [PATCH v2] " Jie Hai
2024-03-15 12:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d40b88-0729-4aae-9fb5-fa84fb12ad79@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=haijie1@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).