From: Yong Wang <yongwang@vmware.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 3/4] vmxnet3: add TSO support
Date: Tue, 5 Jan 2016 23:45:48 +0000 [thread overview]
Message-ID: <73024276-24C7-4818-890F-29160E849B61@vmware.com> (raw)
In-Reply-To: <20160104211431.7331034d@xeon-e3>
On 1/4/16, 9:14 PM, "Stephen Hemminger" <stephen@networkplumber.org> wrote:
>On Mon, 4 Jan 2016 18:28:18 -0800
>Yong Wang <yongwang@vmware.com> wrote:
>
>> + mbuf = txq->cmd_ring.buf_info[eop_idx].m;
>> + if (unlikely(mbuf == NULL))
>> + rte_panic("EOP desc does not point to a valid mbuf");
>> + else
>
>The unlikely is really not needed with rte_panic since it is declared
>with cold attribute which has same effect.
>
>Else is unnecessary because rte_panic never returns.
Done.
next prev parent reply other threads:[~2016-01-05 23:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 2:28 [dpdk-dev] [PATCH v2 0/4] vmxnet3 TSO and tx cksum offload Yong Wang
2016-01-05 2:28 ` [dpdk-dev] [PATCH v2 1/4] vmxnet3: restore tx data ring support Yong Wang
2016-01-05 5:16 ` Stephen Hemminger
2016-01-05 23:27 ` Yong Wang
2016-01-05 2:28 ` [dpdk-dev] [PATCH v2 2/4] vmxnet3: add tx l4 cksum offload Yong Wang
2016-01-05 2:28 ` [dpdk-dev] [PATCH v2 3/4] vmxnet3: add TSO support Yong Wang
2016-01-05 5:14 ` Stephen Hemminger
2016-01-05 23:45 ` Yong Wang [this message]
2016-01-05 5:15 ` Stephen Hemminger
2016-01-05 23:45 ` Yong Wang
2016-01-05 2:28 ` [dpdk-dev] [PATCH v2 4/4] vmxnet3: announce device offload capability Yong Wang
2016-01-05 5:22 ` [dpdk-dev] [PATCH v2 0/4] vmxnet3 TSO and tx cksum offload Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73024276-24C7-4818-890F-29160E849B61@vmware.com \
--to=yongwang@vmware.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).