From: Thomas Monjalon <thomas@monjalon.net>
To: Choonho Son <choonho.son@gmail.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] usertools: fix build with gcc
Date: Wed, 27 Jun 2018 15:31:55 +0200 [thread overview]
Message-ID: <7357136.ipTnM7Ko6i@xps> (raw)
In-Reply-To: <20180621095502.GA436@bricha3-MOBL.ger.corp.intel.com>
21/06/2018 11:55, Bruce Richardson:
> On Thu, Jun 21, 2018 at 09:35:41AM +0000, Choonho Son wrote:
> > dpdk-setup.sh fails to build with lack of environment variable
> >
> > Build complete [x86_64-native-linuxapp-gcc]
> > Installation cannot run with T defined and DESTDIR undefined
> >
> > Signed-off-by: Choonho Son <choonho.son@gmail.com>
> > ---
[...]
> > - make install T=${RTE_TARGET}
> > + make install T=${RTE_TARGET} DESTDIR=${DESTDIR}
>
> The message about no DESTDIR is not really an error, the build has
> completed successfully. I don't think copying the build over to a new
> directory is something we should always do as part of this script.
Absolutely!
The syntax "make install T=" is old.
It should be replaced by "make config T=" + "make".
You can look at devtools/test-build.sh to see how compilation can be done.
It is also documented in various places like:
doc/guides/linux_gsg/build_dpdk.rst
doc/guides/prog_guide/dev_kit_root_make_help.rst
More options:
- use meson build system in dpdk-setup.sh - maybe too early
- remove dpdk-setup.sh - maybe used by real users
prev parent reply other threads:[~2018-06-27 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 9:35 Choonho Son
2018-06-21 9:35 ` Choonho Son
2018-06-21 9:55 ` Bruce Richardson
2018-06-27 13:31 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7357136.ipTnM7Ko6i@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=choonho.son@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).