From: Laszlo Ersek <lersek@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, yliu@fridaylinux.org, tiwei.bie@intel.com,
jianfeng.tan@intel.com, lprosek@redhat.com,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v5 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ not negotiated
Date: Wed, 13 Dec 2017 12:23:32 +0100 [thread overview]
Message-ID: <73a31f43-4c21-457e-dd2d-8e99e6edeabb@redhat.com> (raw)
In-Reply-To: <5fda0d3d-72e0-6506-29a7-c05e8c916858@redhat.com>
On 12/13/17 11:24, Paolo Bonzini wrote:
> On 13/12/2017 11:11, Maxime Coquelin wrote:
>>> Hi Maxime,
>>>
>>> I think this series is wrong from the virtio spec's point of view. If
>>> the driver requests VIRTIO_NET_F_MQ, that does not mean "the driver
>>> knows about multiqueue", it only means that "the driver wants to read
>>> max_virtqueue_pairs" from configuration space.
>>
>> Actually, my series fixes half of the problem, the case where driver
>> does not know about multiqueue.
>>
>> In this case, there is no point in the backend to wait for the
>> initialization of queues that does not exist.
>>
>> So I think my series is not enough, but not wrong.
>
> You're right; what I meant by "wrong" is that it becomes unnecessary if
> you do VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET. But since this requires a
> vhost-user update, doing both makes sense.
Based on this, plus reviewing patch #4 for:
+ vq = dev->virtqueue[--dev->nr_vring];
+ if (!vq)
+ continue;
+
+ dev->virtqueue[dev->nr_vring] = NULL;
Acked-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
next prev parent reply other threads:[~2017-12-13 11:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-13 8:51 Maxime Coquelin
2017-12-13 8:51 ` [dpdk-dev] [PATCH v5 1/4] vhost: prevent features to be changed while device is running Maxime Coquelin
2017-12-13 8:51 ` [dpdk-dev] [PATCH v5 2/4] vhost: propagate VHOST_USER_SET_FEATURES handling error Maxime Coquelin
2017-12-13 8:51 ` [dpdk-dev] [PATCH v5 3/4] vhost: extract virtqueue cleaning and freeing functions Maxime Coquelin
2017-12-13 8:51 ` [dpdk-dev] [PATCH v5 4/4] vhost: destroy unused virtqueues when multiqueue not negotiated Maxime Coquelin
2017-12-13 9:15 ` [dpdk-dev] [PATCH v5 0/4] Vhost: fix mq=on but VIRTIO_NET_F_MQ " Paolo Bonzini
2017-12-13 10:11 ` Maxime Coquelin
2017-12-13 10:24 ` Paolo Bonzini
2017-12-13 11:23 ` Laszlo Ersek [this message]
2018-01-08 14:36 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73a31f43-4c21-457e-dd2d-8e99e6edeabb@redhat.com \
--to=lersek@redhat.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=lprosek@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).