From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Matan Azrad <matan@mellanox.com>, dev@dpdk.org
Cc: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix completion queue arming
Date: Wed, 19 Feb 2020 11:02:09 +0100 [thread overview]
Message-ID: <73ca9972-9743-43af-d073-ca86a0ebf908@redhat.com> (raw)
In-Reply-To: <1582028721-637-1-git-send-email-matan@mellanox.com>
On 2/18/20 1:25 PM, Matan Azrad wrote:
> The mlx5 vDPA driver manages QP and CQ in order to forward the HW event
> to the guest by the callfd file descriptor for each virtq.
>
> The driver arms the CQ for the next CQE index that should be
> completed by the HW in order to create completion event.
>
> In the SW completion event handler, the driver arms the CQ again for the
> next index,
>
> The CQE index in the CQ doorbell and in the CQ doorbell record was
> masked incorrectly with the CQ size mask while it should be masked only
> with 0xFFFFFF mask.
>
> Remove the CQ size mask, stay only with 0xFFFFFF mask.
>
> Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues")
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
> drivers/vdpa/mlx5/mlx5_vdpa_event.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
next prev parent reply other threads:[~2020-02-19 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 12:25 Matan Azrad
2020-02-19 9:15 ` Slava Ovsiienko
2020-02-19 10:02 ` Maxime Coquelin [this message]
2020-02-19 10:23 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73ca9972-9743-43af-d073-ca86a0ebf908@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).