From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>, dev@dpdk.org
Cc: hernan.vargas@intel.com, stable@dpdk.org
Subject: Re: [PATCH v1 1/1] baseband/acc: fix for TB mode on VRB1
Date: Thu, 9 Nov 2023 11:07:12 +0100 [thread overview]
Message-ID: <746183f4-f3f2-4e99-85d1-24698c273999@redhat.com> (raw)
In-Reply-To: <20231103234512.758086-2-nicolas.chautru@intel.com>
On 11/4/23 00:45, Nicolas Chautru wrote:
> The input size is computed incorrectly for the
> LDPC encoder TB processing.
>
> Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc/rte_vrb_pmd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c
> index ae230b828a..686e086a5c 100644
> --- a/drivers/baseband/acc/rte_vrb_pmd.c
> +++ b/drivers/baseband/acc/rte_vrb_pmd.c
> @@ -2218,7 +2218,8 @@ vrb1_enqueue_ldpc_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op
> uint16_t init_enq_descs = enq_descs;
> uint32_t in_offset = 0, out_offset = 0;
>
> - input_len_B = ((op->ldpc_enc.basegraph == 1 ? 22 : 10) * op->ldpc_enc.z_c) >> 3;
> + input_len_B = ((op->ldpc_enc.basegraph == 1 ? 22 : 10) * op->ldpc_enc.z_c
> + - op->ldpc_enc.n_filler) >> 3;
>
> if (check_bit(op->ldpc_enc.op_flags, RTE_BBDEV_LDPC_CRC_24B_ATTACH))
> input_len_B -= 3;
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-11-09 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 23:45 [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD Nicolas Chautru
2023-11-03 23:45 ` [PATCH v1 1/1] baseband/acc: fix for TB mode on VRB1 Nicolas Chautru
2023-11-09 10:07 ` Maxime Coquelin [this message]
2023-11-09 15:50 ` [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=746183f4-f3f2-4e99-85d1-24698c273999@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).