From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yong Wang <wang.yong19@zte.com.cn>, wenzhuo.lu@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] e1000/base: fix multicast setting in VF
Date: Fri, 24 Feb 2017 11:22:57 +0000 [thread overview]
Message-ID: <74bacad4-63db-8836-25cd-ce9495cc5632@intel.com> (raw)
In-Reply-To: <1487669603-13741-1-git-send-email-wang.yong19@zte.com.cn>
On 2/21/2017 9:33 AM, Yong Wang wrote:
> In function e1000_update_mc_addr_list_vf(), "msgbuf[0]" is used prior
> to initialization at "msgbuf[0] |= E1000_VF_SET_MULTICAST_OVERFLOW".
> And "msgbuf[0]" is overwritten at "msgbuf[0] = E1000_VF_SET_MULTICAST".
> Fix it by moving the second line prior to the first one that mentioned
> above.
>
> ---
> v2:
> * According to Thomas's suggestion, modify the title.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
It looks like this fix has a history:
- Defect introduces with initial version
- Fixed with: [1]
06cf9be95ce1 ("lib: fix uninitialized value")
- Fix reverted with: [2]
dffbaf7880a8 ("e1000: revert fix for multicast in VF")
- This patch applies same fix again.
Revert does not mention why it has been reverted, this is one of the
samples why commit log matters.
Since code is clearly wrong, I am for getting the fix, but it would be
nice to know why it has been reverted previously.
[1]
commit 06cf9be95ce16b363c4267d2d17e27c2706629ae
Author: Zijie Pan <zijie.pan@6wind.com>
Date: Thu Dec 6 15:36:51 2012 +0800
lib: fix uninitialized value
Fix warning "The left expression of the compound assignment
is an uninitialized value".
Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
Acked-by: Ivan Boule <ivan.boule@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
[2]
commit dffbaf7880a8d753a4971971256d6c8b90e7ece1
Author: Intel <intel.com>
Date: Fri Nov 8 03:00:00 2013 +0100
e1000: revert fix for multicast in VF
Revert fix from commit 06cf9be95ce16b363c4267d2d17e27c2706629ae.
Signed-off-by: Intel
prev parent reply other threads:[~2017-02-24 11:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 9:33 Yong Wang
2017-02-24 0:32 ` Lu, Wenzhuo
2017-02-24 11:35 ` Ferruh Yigit
2017-02-24 11:22 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74bacad4-63db-8836-25cd-ce9495cc5632@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=wang.yong19@zte.com.cn \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).