From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: David Marchand <david.marchand@redhat.com>,
Ilya Maximets <i.maximets@samsung.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
ShuaiX Zhu <shuaix.zhu@intel.com>,
Xueqin Lin <xueqin.lin@intel.com>,
WenjieX A Li <wenjiex.a.li@intel.com>,
FengqinX Wang <fengqinx.wang@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] test: test zero socket-mem as valid
Date: Fri, 25 Jan 2019 13:48:25 +0000 [thread overview]
Message-ID: <756c04d0-86fd-853d-7f29-6f11a9ec007d@intel.com> (raw)
In-Reply-To: <CAJFAV8ykLfYV2u+EA2eAaFMSUwvT0AyjsNVogriBNrqXz4am9g@mail.gmail.com>
On 25-Jan-19 9:53 AM, David Marchand wrote:
>
>
> On Fri, Jan 25, 2019 at 9:06 AM Ilya Maximets <i.maximets@samsung.com
> <mailto:i.maximets@samsung.com>> wrote:
>
> On 25.01.2019 10:55, Ilya Maximets wrote:
> > Dynamic memory mode allowes zero socket-mem because all the
> > required memory could be allocated on demand.
> >
> > Fixes: 339c2244b4f1 ("eal: fix parsing zero socket memory and
> limits")
> > Cc: stable@dpdk.org <mailto:stable@dpdk.org>
> >
>
> Reported-by: Shuai Zhu <shuaix.zhu@intel.com
> <mailto:shuaix.zhu@intel.com>>
>
> > Signed-off-by: Ilya Maximets <i.maximets@samsung.com
> <mailto:i.maximets@samsung.com>>
>
> > ---
> > test/test/test_eal_flags.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/test/test/test_eal_flags.c b/test/test/test_eal_flags.c
> > index e3a60c7ae..81e345b87 100644
> > --- a/test/test/test_eal_flags.c
> > +++ b/test/test/test_eal_flags.c
> > @@ -1158,7 +1158,7 @@ test_memory_flags(void)
> > const char *argv1[] = {prgname, "-c", "10", "-n", "2",
> > "--file-prefix=" memtest, "-m",
> DEFAULT_MEM_SIZE};
> >
> > - /* invalid (zero) --socket-mem flag */
> > + /* valid (zero) --socket-mem flag */
> > const char *argv2[] = {prgname, "-c", "10", "-n", "2",
> > "--file-prefix=" memtest,
> "--socket-mem=0,0,0,0"};
> >
> > @@ -1256,8 +1256,8 @@ test_memory_flags(void)
> > printf("Error - process failed with valid -m flag!\n");
> > return -1;
> > }
> > - if (launch_proc(argv2) == 0) {
> > - printf("Error - process run ok with invalid (zero)
> --socket-mem!\n");
> > + if (launch_proc(argv2) != 0) {
> > + printf("Error - process failed with valid (zero)
> --socket-mem!\n");
> > return -1;
> > }
> >
> >
>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com
> <mailto:david.marchand@redhat.com>>
>
>
> --
> David Marchand
Now that i think of it, maybe it's not that simple.
--socket-mem/-m flag with zero is still an invalid value *if*
--legacy-mem is involved. However, it is a valid value in non-legacy mode.
So maybe the test should reflect this, and the previous fix should have
instead added a check for legacy mode rather than disabling the zero
check outright.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-01-25 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190125075604eucas1p2ecf0177c3f953e889721d784ef387254@eucas1p2.samsung.com>
2019-01-25 7:55 ` [dpdk-stable] " Ilya Maximets
2019-01-25 8:06 ` Ilya Maximets
2019-01-25 9:53 ` [dpdk-stable] [dpdk-dev] " David Marchand
2019-01-25 13:48 ` Burakov, Anatoly [this message]
2019-01-25 14:00 ` Ilya Maximets
2019-01-25 14:12 ` Burakov, Anatoly
2019-01-26 18:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=756c04d0-86fd-853d-7f29-6f11a9ec007d@intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fengqinx.wang@intel.com \
--cc=i.maximets@samsung.com \
--cc=shuaix.zhu@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=wenjiex.a.li@intel.com \
--cc=xueqin.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).