From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Thomas Monjalon <thomas@monjalon.net>, Rongwei Liu <rongweil@nvidia.com>
Cc: dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com,
orika@nvidia.com, rasland@nvidia.com,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v8] ethdev: add optimization hints in flow template table
Date: Wed, 8 Feb 2023 23:19:35 +0000 [thread overview]
Message-ID: <75dc0e54-2f4f-f8c9-bf27-b6ad8ae01652@amd.com> (raw)
In-Reply-To: <5085921.31r3eYUQgx@thomas>
On 2/2/2023 11:33 AM, Thomas Monjalon wrote:
> 02/02/2023 12:19, Rongwei Liu:
>> In case flow rules match only one kind of traffic in a flow table,
>> then optimization can be done via allocation of this table.
>> Such optimization is possible only if the application gives a hint
>> about its usage of the table during initial configuration.
>>
>> The transfer domain rules may process traffic from wire or vport,
>> which may correspond to two kinds of underlayer resources.
>> That's why the first two hints introduced in this patch are about
>> wire and vport traffic specialization.
>> Wire means traffic arrives from the uplink port while vport means
>> traffic initiated from VF/SF.
>>
>> There are two possible approaches for providing the hints.
>> Using IPv4 as an example:
>> 1. Use pattern item in both flow template table and rules.
>>
>> template table 3 =
>> transfer pattern ANY_VPORT / eth / ipv4 src is 255.255.255.255 / end
>> flow rule =
>> template_table 3 pattern ANY_VPORT / eth / ipv4 src is 1.1.1.1 / end
>>
>> The pattern template 3 will be used only to match flows coming from
>> vports.
>> ANY_VPORT needs to be present in each flow rule.
>> ANY_VPORT matching is redundant with IP src 1.1.1.1 because
>> the user knows 1.1.1.1 is the IP of a vport.
>>
>> 2. Add specialization flag into flow template table attribute:
>>
>> template table 3 =
>> transfer VPORT_ORIG pattern eth / ipv4 src is 255.255.255.255 / end
>> flow rule =
>> template_table 3 pattern eth / ipv4 src is 1.1.1.1 / end
>>
>> The pattern template 3 can be used only to match flows coming
>> from vports.
>>
>> Approach 1 needs to specify the hint in each flow rule that wastes
>> memory and is not user friendly.
>> This patch takes the 2nd approach and introduces one new member
>> "specialize" into rte_flow_table_attr to indicate possible flow table
>> optimization.
>>
>> By default, there is no hint, so nothing change.
>> There is no guarantee that the hints will be effective in the driver.
>> The application functionality must not rely on the hints.
>>
>> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
>> Acked-by: Ori Kam <orika@nvidia.com>
>
> Andrew gave this recent comment on v7:
> "
> Anyway, hint itself is OK and makes sense. Hopefully
> documentation highlights that pattern match is required.
> If so,
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> "
>
> Given the lines below, I assume the documentation is OK.
>
>> +This attribute is not mandatory for driver to implement.
>> +If a hint is not supported, it will be silently ignored,
>> +and no special optimization is done.
>> +
>> +If a table is specialized, the application should make sure the rules
>> +comply with the table attribute.
>> +The application functionality must not rely on the hints,
>> +they are not replacing the matching criteria of flow rules.
> [...]
>> +/**@{@name Flags for template table attribute.
>> + * Each bit is an optional hint for table specialization,
>> + * offering a potential optimization at driver layer.
>> + * The driver can ignore the hints silently.
>> + * The hints do not replace any matching criteria.
>> + */
>> +/**
>> + * Specialize table for transfer flows which come only from wire.
>> + * It allows PMD not to allocate resources for non-wire originated traffic.
>> + * This bit is not a matching criteria, just an optimization hint.
>> + * Flow rules which match non-wire originated traffic will be missed
>> + * if the hint is supported.
>> + */
>> +#define RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_WIRE_ORIG RTE_BIT32(0)
>> +/**
>> + * Specialize table for transfer flows which come only from vport (e.g. VF, SF).
>> + * It allows PMD not to allocate resources for non-vport originated traffic.
>> + * This bit is not a matching criteria, just an optimization hint.
>> + * Flow rules which match non-vport originated traffic will be missed
>> + * if the hint is supported.
>> + */
>> +#define RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_VPORT_ORIG RTE_BIT32(1)
>> +/**@}*/
> [...]
>> + /**
>> + * Optional hint flags for driver optimization.
>> + * The effect may vary in the different drivers.
>> + * The functionality must not rely on the hints.
>> + * Value is composed with RTE_FLOW_TABLE_SPECIALIZE_* based on application
>> + * design choices.
>> + * Misused hints may mislead the driver, it may result in an undefined behavior.
>> + */
>> + uint32_t specialize;
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
Applied to dpdk-next-net/main, thanks.
next prev parent reply other threads:[~2023-02-08 23:19 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 2:40 [PATCH v1] ethdev: add direction info when creating the transfer table Rongwei Liu
2022-09-11 8:22 ` Ori Kam
2022-09-12 16:57 ` Ivan Malov
2022-09-13 13:46 ` Rongwei Liu
2022-09-13 14:33 ` Ivan Malov
2022-09-14 5:16 ` Rongwei Liu
2022-09-14 7:32 ` Ivan Malov
2022-09-14 10:17 ` Rongwei Liu
2022-09-14 15:18 ` Ivan Malov
2022-09-14 21:02 ` Thomas Monjalon
2022-09-15 0:58 ` Rongwei Liu
2022-09-15 7:47 ` Ivan Malov
2022-09-15 8:18 ` Thomas Monjalon
2022-09-15 9:42 ` Ivan Malov
2022-09-15 8:48 ` Rongwei Liu
2022-09-15 10:59 ` Ivan Malov
2022-09-15 11:16 ` Thomas Monjalon
2022-09-20 9:41 ` Ori Kam
2022-09-20 12:45 ` Ivan Malov
2022-09-20 13:59 ` Ori Kam
2022-09-20 15:28 ` Ivan Malov
2022-09-21 7:34 ` Ori Kam
2022-09-21 8:39 ` Andrew Rybchenko
2022-09-21 9:04 ` Ivan Malov
2022-09-21 9:40 ` Thomas Monjalon
2022-09-21 10:04 ` Andrew Rybchenko
2022-09-21 12:41 ` Ori Kam
2022-09-21 12:51 ` Morten Brørup
2022-09-22 7:39 ` Andrew Rybchenko
2022-09-22 10:06 ` Ori Kam
2022-09-22 10:31 ` Andrew Rybchenko
2022-09-22 13:00 ` Ori Kam
2022-09-23 7:25 ` Andrew Rybchenko
2022-09-23 16:11 ` Ori Kam
2022-09-22 12:43 ` Ivan Malov
2022-09-22 14:46 ` Ori Kam
2022-09-28 9:24 ` [PATCH v3] ethdev: add hint when creating async " Rongwei Liu
2022-10-04 8:31 ` Andrew Rybchenko
2022-11-04 10:42 ` [PATCH v4] ethdev: add special flags " Rongwei Liu
2022-11-04 10:44 ` Rongwei Liu
2022-11-08 11:39 ` Andrew Rybchenko
2022-11-08 11:47 ` Andrew Rybchenko
2022-11-08 13:29 ` Thomas Monjalon
2022-11-08 14:38 ` Andrew Rybchenko
2022-11-08 15:25 ` Thomas Monjalon
2022-11-09 8:53 ` Andrew Rybchenko
2022-11-09 9:03 ` Thomas Monjalon
2022-11-09 9:36 ` Andrew Rybchenko
2022-11-09 10:50 ` Thomas Monjalon
2022-11-06 10:02 ` [PATCH v3] ethdev: add hint " Andrew Rybchenko
2022-11-07 1:58 ` Rongwei Liu
2022-11-08 9:19 ` Thomas Monjalon
2022-11-08 9:35 ` Andrew Rybchenko
2022-11-08 11:18 ` Thomas Monjalon
2022-11-08 11:48 ` Andrew Rybchenko
2022-11-14 8:47 ` [PATCH v6] ethdev: add special flags " Rongwei Liu
2022-11-14 11:59 ` [PATCH v7] " Rongwei Liu
2023-01-17 15:13 ` Ferruh Yigit
2023-01-17 17:01 ` Ferruh Yigit
2023-01-18 2:50 ` Rongwei Liu
2023-01-18 7:30 ` Andrew Rybchenko
2023-01-18 7:28 ` Andrew Rybchenko
2023-01-18 16:18 ` Thomas Monjalon
2023-02-01 10:17 ` Andrew Rybchenko
2023-02-01 10:58 ` Thomas Monjalon
2023-02-01 11:10 ` Andrew Rybchenko
2023-02-01 11:18 ` Thomas Monjalon
2023-02-01 11:38 ` Andrew Rybchenko
2023-02-01 13:48 ` Thomas Monjalon
2023-02-02 9:21 ` Andrew Rybchenko
2023-02-02 11:29 ` Thomas Monjalon
2023-02-02 12:24 ` Andrew Rybchenko
2023-02-01 11:22 ` Ori Kam
2023-02-01 11:29 ` Andrew Rybchenko
2023-02-01 11:12 ` Ori Kam
2023-02-01 11:20 ` Thomas Monjalon
2023-01-30 0:00 ` Ivan Malov
2023-01-30 2:34 ` Rongwei Liu
2023-01-30 7:40 ` Ivan Malov
2023-01-30 14:49 ` Rongwei Liu
2023-01-30 23:00 ` Ivan Malov
2023-01-31 3:06 ` Rongwei Liu
2023-01-31 5:30 ` Ivan Malov
2023-01-31 6:14 ` Rongwei Liu
2023-02-01 10:12 ` Thomas Monjalon
2023-02-01 11:50 ` Ivan Malov
2023-02-01 13:37 ` Thomas Monjalon
2023-02-01 14:04 ` Ivan Malov
2023-02-01 14:23 ` Thomas Monjalon
2023-02-01 14:29 ` Ori Kam
2023-02-02 11:19 ` [PATCH v8] ethdev: add optimization hints in flow template table Rongwei Liu
2023-02-02 11:33 ` Thomas Monjalon
2023-02-08 23:19 ` Ferruh Yigit [this message]
2022-11-09 8:11 ` [PATCH v5] ethdev: add special flags when creating async transfer table Rongwei Liu
2022-11-09 8:13 ` Rongwei Liu
2022-11-09 8:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75dc0e54-2f4f-f8c9-bf27-b6ad8ae01652@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).