From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maryam Tahhan <maryam.tahhan@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: add additional error stats
Date: Wed, 17 Jun 2015 16:01:18 +0200 [thread overview]
Message-ID: <7603426.jST2jPJP37@xps13> (raw)
In-Reply-To: <20150609172954.173d26d0@urahara>
2015-06-09 17:29, Stephen Hemminger:
> On Tue, 9 Jun 2015 16:10:40 +0100
> Maryam Tahhan <maryam.tahhan@intel.com> wrote:
>
> > Add MAC error and drop statistics to struct rte_eth_stats and the
> > extended stats.
> > Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> > ---
> > lib/librte_ether/rte_ethdev.c | 4 ++++
> > lib/librte_ether/rte_ethdev.h | 4 ++++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
> > index 5a94654..a439b4a 100644
> > --- a/lib/librte_ether/rte_ethdev.c
> > +++ b/lib/librte_ether/rte_ethdev.c
> > @@ -136,6 +136,10 @@ static const struct rte_eth_xstats_name_off rte_stats_strings[] = {
> > {"rx_flow_control_xon", offsetof(struct rte_eth_stats, rx_pause_xon)},
> > {"tx_flow_control_xoff", offsetof(struct rte_eth_stats, tx_pause_xoff)},
> > {"rx_flow_control_xoff", offsetof(struct rte_eth_stats, rx_pause_xoff)},
> > + {"rx_mac_err", offsetof(struct rte_eth_stats, imacerr)},
> > + {"rx_phy_err", offsetof(struct rte_eth_stats, iphyerr)},
> > + {"tx_drops", offsetof(struct rte_eth_stats, odrop)},
> > + {"rx_drops", offsetof(struct rte_eth_stats, idrop)}
>
> Are these really generic enough to put them in ethdev?
No, as explained here:
http://dpdk.org/ml/archives/dev/2015-June/019550.html
Please rework.
Thanks
next prev parent reply other threads:[~2015-06-17 14:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 15:10 [dpdk-dev] [PATCH v2 0/7] Expose IXGBE extended stats to DPDK apps Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 1/7] ethdev: add additional error stats Maryam Tahhan
2015-06-10 0:29 ` Stephen Hemminger
2015-06-17 14:01 ` Thomas Monjalon [this message]
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 2/7] ixgbe: move stats register reads to a new function Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 3/7] ixgbe: Expose extended error statistics Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 4/7] ethdev: expose extended error stats Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 5/7] testpmd: extend testpmd to show all extended stats Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 6/7] app: remove dump_cfg Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 7/7] app: add a new app proc_info Maryam Tahhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7603426.jST2jPJP37@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=maryam.tahhan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).