From: "Nicolau, Radu" <radu.nicolau@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"pascal.mazon@6wind.com" <pascal.mazon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions
Date: Fri, 15 Dec 2017 16:34:28 +0000 [thread overview]
Message-ID: <763A2F19A5EFF34F8B7F1657C992EE297B303ECB@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20171215081956.29362ae1@xeon-e3>
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, December 15, 2017 4:20 PM
> To: Nicolau, Radu <radu.nicolau@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>;
> pascal.mazon@6wind.com
> Subject: Re: [dpdk-dev] [PATCH] net/tap: renamed netlink functions
>
> On Fri, 15 Dec 2017 11:34:37 +0000
> Radu Nicolau <radu.nicolau@intel.com> wrote:
>
> > Functions like nl_recev and nl_send name clash functions in the libnl
> > library (https://www.infradead.org/~tgr/libnl/).
> > All functions declared in tap_netlink.h were decorated with tap_ for
> > consistency.
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> > ---
>
> This make sense to fix, but name clash should only matter if tap PMD and
> libnl were statically linked in same application. Wouldn't that be a license
> violation.
The tap PMD is statically linked, but libnl is not, still this leads to symbol names clashing. Application that needs the functions from libnl (silently) ends up with the ones in tap PMD.
next prev parent reply other threads:[~2017-12-15 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 11:34 Radu Nicolau
2017-12-15 11:58 ` Bruce Richardson
2017-12-15 12:04 ` Nicolau, Radu
2017-12-15 16:19 ` Stephen Hemminger
2017-12-15 16:34 ` Nicolau, Radu [this message]
2017-12-15 17:51 ` Ferruh Yigit
2018-01-09 11:26 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=763A2F19A5EFF34F8B7F1657C992EE297B303ECB@IRSMSX104.ger.corp.intel.com \
--to=radu.nicolau@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pascal.mazon@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).