From: "Nicolau, Radu" <radu.nicolau@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhao, XinfengX" <xinfengx.zhao@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: check if security capabilities are enabled by HW
Date: Wed, 17 Jan 2018 11:40:25 +0000 [thread overview]
Message-ID: <763A2F19A5EFF34F8B7F1657C992EE297B30F266@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772588627EE87@irsmsx105.ger.corp.intel.com>
> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Wednesday, January 17, 2018 11:34 AM
> To: Nicolau, Radu <radu.nicolau@intel.com>; dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao, XinfengX
> <xinfengx.zhao@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: RE: [PATCH] net/ixgbe: check if security capabilities are enabled by
> HW
>
> Hi Radu,
>
> > -----Original Message-----
> > From: Nicolau, Radu
> > Sent: Wednesday, January 17, 2018 11:19 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> > <konstantin.ananyev@intel.com>; Zhao, XinfengX
> > <xinfengx.zhao@intel.com>; De Lara Guarch, Pablo
> > <pablo.de.lara.guarch@intel.com>; Nicolau, Radu
> > <radu.nicolau@intel.com>
> > Subject: [PATCH] net/ixgbe: check if security capabilities are enabled
> > by HW
> >
> > Check if the security enable bits are not fused before setting offload
> > capabilities for security
>
> In theory dev_info_get() - could be called at any stage of device
> configuration or even when RX/TX is active.
> Do you really want to assert SECRXCTRL at that moment?
> Probably better to do this only once at init time and then just use some
> stored value?
> Konstantin
>
Yes, that's true. I will send a v2
next prev parent reply other threads:[~2018-01-17 11:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 11:19 Radu Nicolau
2018-01-17 11:34 ` Ananyev, Konstantin
2018-01-17 11:40 ` Nicolau, Radu [this message]
2018-01-17 11:54 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2018-01-17 22:47 ` Ananyev, Konstantin
2018-01-18 0:43 ` Zhang, Helin
2018-01-18 14:58 ` Ferruh Yigit
2018-01-20 9:45 ` Zhang, Helin
2018-01-18 12:46 ` [dpdk-dev] [PATCH v3] net/ixgbe: check security enable bits Radu Nicolau
2018-01-22 10:23 ` Ananyev, Konstantin
2018-01-23 2:06 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=763A2F19A5EFF34F8B7F1657C992EE297B30F266@IRSMSX104.ger.corp.intel.com \
--to=radu.nicolau@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xinfengx.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).