From: Kevin Traynor <ktraynor@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Hyong Youb Kim <hyonkim@cisco.com>
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>,
"stable@dpdk.org" <stable@dpdk.org>,
Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 13/13] net/enic: fix several issues with inner packet matching
Date: Wed, 10 Apr 2019 18:06:29 +0100 [thread overview]
Message-ID: <76447a14-5774-8c96-e2d7-2b7912b26c26@redhat.com> (raw)
In-Reply-To: <bac17e86-943a-3520-b8f4-8ec1dc005c7c@intel.com>
On 04/03/2019 16:58, Ferruh Yigit wrote:
> On 3/2/2019 10:42 AM, Hyong Youb Kim wrote:
>> Inner packet matching is currently buggy in many cases.
>>
>> 1. Mishandling null spec ("match any").
>> The copy_item functions do nothing if spec is null. This is incorrect,
>> as all patterns should be appended to the L5 pattern buffer even for
>> null spec (treated as all zeros).
>>
>> 2. Accessing null spec causing segfault.
>>
>> 3. Not setting protocol fields.
>> The NIC filter API currently has no flags for "match inner IPv4, IPv6,
>> UDP, TCP, and so on". So, the driver needs to explicitly set EtherType
>> and IP protocol fields in the L5 pattern buffer to avoid false
>> positives (e.g. reporting IPv6 as IPv4).
>>
>> Instead of keep adding "if inner, do something differently" cases to
>> the existing copy_item functions, introduce separate functions for
>> inner packet patterns and address the above issues in those
>> functions. The changes to the previous outer-packet copy_item
>> functions are mechanical, due to reduced indentation.
>>
>> Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled")
>>
>> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
>
> <...>
>
> I have added "Cc: stable@dpdk.org" tag while merging. If the tag explicitly left
> out to prevent backport please let me know to remove the tag back.
>
Hi Hyong,
I can't apply this patch with confidence on the 18.11 LTS branch due to
the amount of changes and conflicts. The other relevant patches in the
series for 18.11 were ok.
If you want the fixes from this patch on stable branches, can you please
send a backport for them
(http://doc.dpdk.org/guides/contributing/patches.html?highlight=stable#backporting-patches-for-stable-releases).
Otherwise, please let us know that you don't want them on stable branches.
thanks,
Kevin.
prev parent reply other threads:[~2019-04-10 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190302104251.32565-1-hyonkim@cisco.com>
2019-03-02 10:42 ` [dpdk-stable] [PATCH v2 02/13] net/enic: fix flow director SCTP matching Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-stable] [PATCH v2 03/13] net/enic: fix SCTP match for flow API Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-stable] [PATCH v2 04/13] net/enic: allow flow mark ID 0 Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-stable] [PATCH v2 05/13] net/enic: check for unsupported flow item types Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-stable] [PATCH v2 10/13] net/enic: reset VXLAN port regardless of overlay offload Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-stable] [PATCH v2 11/13] net/enic: fix a couple issues with VXLAN match Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-stable] [PATCH v2 12/13] net/enic: fix an endian bug in VLAN match Hyong Youb Kim
[not found] ` <20190302104251.32565-14-hyonkim@cisco.com>
[not found] ` <bac17e86-943a-3520-b8f4-8ec1dc005c7c@intel.com>
2019-04-10 17:06 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76447a14-5774-8c96-e2d7-2b7912b26c26@redhat.com \
--to=ktraynor@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).