From: Patrick MacArthur <patrick@patrickmacarthur.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, mark.b.kavanagh@intel.com,
stephen@networkplumber.org, markus.theil@tu-ilmenau.de,
Patrick MacArthur <pmacarth@iol.unh.edu>,
Bob Noseworthy <ren@iol.unh.edu>,
"O'Driscoll, Tim" <tim.odriscoll@intel.com>
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix unknown symbols
Date: Thu, 12 Oct 2017 23:21:08 -0400 [thread overview]
Message-ID: <7673fa98-986e-abde-a68c-01809d01caec@patrickmacarthur.net> (raw)
In-Reply-To: <20171013024644.51248-1-ferruh.yigit@intel.com>
On 10/12/2017 10:46 PM, Ferruh Yigit wrote:
> This patch partially reverts the commit d196343a258e and adds some
> functions from Markus' previous version of the patch [1].
>
> igb_uio uses pci_msi_unmask_irq() and pci_msi_mask_irq() kernel APIs
> when kernel version is >= 3.19 because these APIs are implemented in
> this Linux kernel version.
>
> But these APIs only exported beginning from Linux kernel 4.5, so before
> this Linux kernel version igb_uio kernel module is not usable,
> and giving following warnings:
> "igb_uio: Unknown symbol pci_msi_unmask_irq"
> "igb_uio: Unknown symbol pci_msi_mask_irq"
>
> The support for these APIs increased to Linux kernel >= 4.5
>
> For older version of Linux kernel unmask_msi_irq() and mask_msi_irq()
> are used but these functions are not exported at all.
> Instead of these functions switched back to previous implementation in
> igb_uio for MSI-X, and for MSI used igbuio_msi_mask_irq() from [1].
>
> Fixes: d196343a258e ("igb_uio: use kernel functions for masking MSI-X")
> Cc: markus.theil@tu-ilmenau.de
>
> [1]
> http://dpdk.org/dev/patchwork/patch/28144/
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
I can confirm that with this patch applied I am able to build and load
the igb_uio module on CentOS 7.4. I have not tested the actual MSI-X
interrupt mask/unmask functionality.
next prev parent reply other threads:[~2017-10-13 3:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 2:46 Ferruh Yigit
2017-10-13 2:51 ` Ferruh Yigit
2017-10-13 16:03 ` [dpdk-dev] [PATCH] igb_uio: fix legacy msi masking Markus Theil
2017-10-13 17:03 ` Ferruh Yigit
2017-10-13 19:54 ` Ferruh Yigit
2017-10-13 3:21 ` Patrick MacArthur [this message]
2017-10-13 13:54 ` [dpdk-dev] [PATCH] igb_uio: fix unknown symbols Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7673fa98-986e-abde-a68c-01809d01caec@patrickmacarthur.net \
--to=patrick@patrickmacarthur.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mark.b.kavanagh@intel.com \
--cc=markus.theil@tu-ilmenau.de \
--cc=pmacarth@iol.unh.edu \
--cc=ren@iol.unh.edu \
--cc=stephen@networkplumber.org \
--cc=tim.odriscoll@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).