From: Yongseok Koh <yskoh@mellanox.com>
To: Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/3] net/mlx5: add Netlink message size check in rule cleanup
Date: Sun, 11 Nov 2018 11:39:30 +0000 [thread overview]
Message-ID: <7697EB15-EEED-4049-BD32-4FD40F9DF3C1@mellanox.com> (raw)
In-Reply-To: <1541843951-31708-3-git-send-email-viacheslavo@mellanox.com>
> On Nov 10, 2018, at 1:59 AM, Slava Ovsiienko <viacheslavo@mellanox.com> wrote:
>
> This patch is preparation for the following fix, we are going to send
> Netlink message from buffer in one-by-one fashion. It is highly
> desirable to check multimessage buffer consistency for debug purposes.
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
> drivers/net/mlx5/mlx5_flow_tcf.c | 33 ++++++++++++++++++++-------------
> 1 file changed, 20 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_tcf.c b/drivers/net/mlx5/mlx5_flow_tcf.c
> index ba0674a..bba8aed 100644
> --- a/drivers/net/mlx5/mlx5_flow_tcf.c
> +++ b/drivers/net/mlx5/mlx5_flow_tcf.c
> @@ -3935,6 +3935,7 @@ struct tcf_nlcb_context {
> struct nlattr *na_local = NULL;
> struct nlattr *na_peer = NULL;
> unsigned char family;
> + uint32_t size;
>
> if (nlh->nlmsg_type != RTM_NEWADDR) {
> rte_errno = EINVAL;
> @@ -3962,11 +3963,11 @@ struct tcf_nlcb_context {
> if (!na_local || !na_peer)
> return 1;
> /* Local rule found with scope link, permanent and assigned peer. */
> - cmd = flow_tcf_alloc_nlcmd(ctx, MNL_ALIGN(sizeof(struct nlmsghdr)) +
> - MNL_ALIGN(sizeof(struct ifaddrmsg)) +
> - (family == AF_INET6
> - ? 2 * SZ_NLATTR_DATA_OF(IPV6_ADDR_LEN)
> - : 2 * SZ_NLATTR_TYPE_OF(uint32_t)));
> + size = MNL_ALIGN(sizeof(struct nlmsghdr)) +
> + MNL_ALIGN(sizeof(struct ifaddrmsg)) +
> + (family == AF_INET6 ? 2 * SZ_NLATTR_DATA_OF(IPV6_ADDR_LEN)
> + : 2 * SZ_NLATTR_TYPE_OF(uint32_t));
> + cmd = flow_tcf_alloc_nlcmd(ctx, size);
> if (!cmd) {
> rte_errno = ENOMEM;
> return -rte_errno;
> @@ -3991,6 +3992,7 @@ struct tcf_nlcb_context {
> mnl_attr_put(cmd, IFA_ADDRESS, IPV6_ADDR_LEN,
> mnl_attr_get_payload(na_peer));
> }
> + assert(size == cmd->nlmsg_len);
> return 1;
> }
>
> @@ -4059,6 +4061,7 @@ struct tcf_nlcb_context {
> struct nlattr *na_ip = NULL;
> struct nlattr *na_mac = NULL;
> unsigned char family;
> + uint32_t size;
>
> if (nlh->nlmsg_type != RTM_NEWNEIGH) {
> rte_errno = EINVAL;
> @@ -4085,12 +4088,12 @@ struct tcf_nlcb_context {
> if (!na_mac || !na_ip)
> return 1;
> /* Neigh rule with permenent attribute found. */
> - cmd = flow_tcf_alloc_nlcmd(ctx, MNL_ALIGN(sizeof(struct nlmsghdr)) +
> - MNL_ALIGN(sizeof(struct ndmsg)) +
> - SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) +
> - (family == AF_INET6
> - ? SZ_NLATTR_DATA_OF(IPV6_ADDR_LEN)
> - : SZ_NLATTR_TYPE_OF(uint32_t)));
> + size = MNL_ALIGN(sizeof(struct nlmsghdr)) +
> + MNL_ALIGN(sizeof(struct ndmsg)) +
> + SZ_NLATTR_DATA_OF(ETHER_ADDR_LEN) +
> + (family == AF_INET6 ? SZ_NLATTR_DATA_OF(IPV6_ADDR_LEN)
> + : SZ_NLATTR_TYPE_OF(uint32_t));
> + cmd = flow_tcf_alloc_nlcmd(ctx, size);
> if (!cmd) {
> rte_errno = ENOMEM;
> return -rte_errno;
> @@ -4113,6 +4116,7 @@ struct tcf_nlcb_context {
> }
> mnl_attr_put(cmd, NDA_LLADDR, ETHER_ADDR_LEN,
> mnl_attr_get_payload(na_mac));
> + assert(size == cmd->nlmsg_len);
> return 1;
> }
>
> @@ -4179,6 +4183,7 @@ struct tcf_nlcb_context {
> struct nlattr *na_vxlan = NULL;
> bool found = false;
> unsigned int vxindex;
> + uint32_t size;
>
> if (nlh->nlmsg_type != RTM_NEWLINK) {
> rte_errno = EINVAL;
> @@ -4224,8 +4229,9 @@ struct tcf_nlcb_context {
> return 1;
> /* Attached VXLAN device found, store the command to delete. */
> vxindex = ifm->ifi_index;
> - cmd = flow_tcf_alloc_nlcmd(ctx, MNL_ALIGN(sizeof(struct nlmsghdr)) +
> - MNL_ALIGN(sizeof(struct ifinfomsg)));
> + size = MNL_ALIGN(sizeof(struct nlmsghdr)) +
> + MNL_ALIGN(sizeof(struct ifinfomsg));
> + cmd = flow_tcf_alloc_nlcmd(ctx, size);
> if (!cmd) {
> rte_errno = ENOMEM;
> return -rte_errno;
> @@ -4236,6 +4242,7 @@ struct tcf_nlcb_context {
> ifm = mnl_nlmsg_put_extra_header(cmd, sizeof(*ifm));
> ifm->ifi_family = AF_UNSPEC;
> ifm->ifi_index = vxindex;
> + assert(size == cmd->nlmsg_len);
> return 1;
> }
>
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2018-11-11 11:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 9:59 [dpdk-dev] [PATCH 0/3] fix VXLAN related rules cleanup and management Slava Ovsiienko
2018-11-10 9:59 ` [dpdk-dev] [PATCH 1/3] net/mlx5: fix buffer allocation check in rule cleanup Slava Ovsiienko
2018-11-11 11:35 ` Yongseok Koh
2018-11-10 9:59 ` [dpdk-dev] [PATCH 2/3] net/mlx5: add Netlink message size " Slava Ovsiienko
2018-11-11 11:39 ` Yongseok Koh [this message]
2018-11-10 9:59 ` [dpdk-dev] [PATCH 3/3] net/mlx5: fix rule cleanup Netlink command sending Slava Ovsiienko
2018-11-11 11:41 ` Yongseok Koh
2018-11-12 5:25 ` Slava Ovsiienko
2018-11-11 12:42 ` [dpdk-dev] [PATCH 0/3] fix VXLAN related rules cleanup and management Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7697EB15-EEED-4049-BD32-4FD40F9DF3C1@mellanox.com \
--to=yskoh@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).