From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: print Rx/Tx offload values
Date: Mon, 12 Mar 2018 17:46:14 +0000 [thread overview]
Message-ID: <769d866a-0d16-1495-3f66-d05f52068570@intel.com> (raw)
In-Reply-To: <5CD4CA47-AC99-42DB-8C09-DD235DF27195@mellanox.com>
On 3/12/2018 5:26 PM, Yongseok Koh wrote:
>
>> On Mar 12, 2018, at 8:05 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> Which per port offloads are enabled is not clear. Printing offloads
>> values at forwarding start.
>>
>> CRC strip offload value was printed in more verbose manner, it is
>> removed since Rx/Tx offload values covers it and printing only CRC one
>> can cause confusion.
>>
>> Hexadecimal offloads values are not very user friendly but preferred to
>> not create to much noise during forwarding start.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Shahaf Shuler <shahafs@mellanox.com>
>> Cc: Yongseok Koh <yskoh@mellanox.com>
>>
>> v2:
>> * Add Rxq and Txq stats too
>> * Split Rx an Tx related logs and place them related group
>> ---
>> app/test-pmd/config.c | 13 +++++++------
>> 1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
>> index 4bb255c62..6249b19bb 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -1682,10 +1682,6 @@ rxtx_config_display(void)
>> struct rte_eth_txconf *tx_conf = &ports[pid].tx_conf;
>>
>> printf(" port %d:\n", (unsigned int)pid);
>> - printf(" CRC stripping %s\n",
>> - (ports[pid].dev_conf.rxmode.offloads &
>> - DEV_RX_OFFLOAD_CRC_STRIP) ?
>> - "enabled" : "disabled");
>> printf(" RX queues=%d - RX desc=%d - RX free threshold=%d\n",
>> nb_rxq, nb_rxd, rx_conf->rx_free_thresh);
>> printf(" RX threshold registers: pthresh=%d hthresh=%d "
>> @@ -1693,6 +1689,9 @@ rxtx_config_display(void)
>> rx_conf->rx_thresh.pthresh,
>> rx_conf->rx_thresh.hthresh,
>> rx_conf->rx_thresh.wthresh);
>> + printf(" Rx offloads=0x%"PRIx64" RXQ Offloads=0x%"PRIx64"\n",
>> + ports[pid].dev_conf.rxmode.offloads,
>> + rx_conf->offloads);
>> printf(" TX queues=%d - TX desc=%d - TX free threshold=%d\n",
>> nb_txq, nb_txd, tx_conf->tx_free_thresh);
>> printf(" TX threshold registers: pthresh=%d hthresh=%d "
>> @@ -1700,8 +1699,10 @@ rxtx_config_display(void)
>> tx_conf->tx_thresh.pthresh,
>> tx_conf->tx_thresh.hthresh,
>> tx_conf->tx_thresh.wthresh);
>> - printf(" TX RS bit threshold=%d - TXQ offloads=0x%"PRIx64"\n",
>> - tx_conf->tx_rs_thresh, tx_conf->offloads);
>> + printf(" TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh);
>> + printf(" Tx Offloads=0x%"PRIx64" TXQ offloads=0x%"PRIx64"\n",
>
> Small comment. It would be better to be consistent between "Offloads" and "offloads"
> for Rx and Tx. :-)
Right :) I will send a new version.
>
> Other than that,
>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
> Thanks
>
next prev parent reply other threads:[~2018-03-12 17:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 16:28 [dpdk-dev] [PATCH] " Ferruh Yigit
2018-03-07 21:36 ` Yongseok Koh
2018-03-09 18:27 ` Ferruh Yigit
2018-03-12 14:59 ` Ferruh Yigit
2018-03-12 15:05 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-03-12 17:26 ` Yongseok Koh
2018-03-12 17:46 ` Ferruh Yigit [this message]
2018-03-12 17:53 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2018-03-13 9:24 ` Van Haaren, Harry
2018-03-13 10:21 ` Ferruh Yigit
2018-03-13 11:06 ` Van Haaren, Harry
2018-04-22 23:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=769d866a-0d16-1495-3f66-d05f52068570@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=shahafs@mellanox.com \
--cc=wenzhuo.lu@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).