From: Radu Nicolau <radu.nicolau@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Hunt, David" <david.hunt@intel.com>, "Yao, Lei A" <lei.a.yao@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init failure
Date: Fri, 27 Jul 2018 10:56:40 +0100 [thread overview]
Message-ID: <76f02afd-a7b3-7f7f-3772-badd050cb6ee@intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F903230@IRSMSX107.ger.corp.intel.com>
On 7/26/2018 6:39 PM, De Lara Guarch, Pablo wrote:
> Hi Radu,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Radu Nicolau
>> Sent: Wednesday, July 18, 2018 2:50 PM
>> To: dev@dpdk.org
>> Cc: Hunt, David <david.hunt@intel.com>; Yao, Lei A <lei.a.yao@intel.com>;
>> Nicolau, Radu <radu.nicolau@intel.com>
>> Subject: [dpdk-dev] [PATCH] examples/l3fw-power: do not exit on power lib init
>> failure
>>
>> Do not exit the application if power library fails to initialize or high performance
>> cores configuration cannot be used.
> I would say this deserves more explanation. It doesn't look correct to me to keep log an error that
> the power library couldn't be initialized and still the sample application keeps running.
The application can also be used without the power library features, and
this was also the previous behavior, before high/regular performance
core feature was added.
>
> Actually, the way init_power_library is coded, it returns the output of the call of rte_power_init on the last core
> (ret is overwritten for each core), which looks wrong to me.
I will update init_power_library to return -1 if rte_power_init fails
for at least one core.
>
> Thanks,
> Pablo
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> ---
next prev parent reply other threads:[~2018-07-27 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 13:49 Radu Nicolau
2018-07-26 17:39 ` De Lara Guarch, Pablo
2018-07-27 9:56 ` Radu Nicolau [this message]
2018-07-27 9:53 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2018-08-05 20:26 ` Thomas Monjalon
2018-08-07 13:16 ` Hunt, David
2018-08-07 13:24 ` [dpdk-dev] [PATCH v3] " Radu Nicolau
2018-08-07 15:45 ` Hunt, David
2018-08-07 16:50 ` Radu Nicolau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76f02afd-a7b3-7f7f-3772-badd050cb6ee@intel.com \
--to=radu.nicolau@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=lei.a.yao@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).