From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix build with GCC 6 or prior
Date: Tue, 30 Jan 2018 15:01:07 +0100 [thread overview]
Message-ID: <7749257.NxZygTFbjZ@xps> (raw)
In-Reply-To: <1517304210-15061-1-git-send-email-hemant.agrawal@nxp.com>
30/01/2018 10:23, Hemant Agrawal:
> This patch fixes the compilation with compiler GCC < 7
>
> dpaa2_sec/hw/rta/operation_cmd.h:12:32: error: unknown option after
> ‘#pragma GCC diagnostic’ kind [-Werror=pragmas]
> #pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
>
> Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7")
Sorry for having broken it with a quick fix yesterday.
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
[...]
> +#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION > 70000)
> #pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
> +#endif
I think it must be GCC_VERSION >= 70000
Applied with this change, thanks
prev parent reply other threads:[~2018-01-30 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 9:23 Hemant Agrawal
2018-01-30 14:01 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7749257.NxZygTFbjZ@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).