patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Laatz, Kevin" <kevin.laatz@intel.com>,
	dev@dpdk.org, stable@dpdk.org,
	Reshma Pattan <reshma.pattan@intel.com>,
	Flavia Musatescu <flavia.musatescu@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] telemetry: fix build
Date: Fri, 28 Jun 2019 11:28:59 +0100	[thread overview]
Message-ID: <7808db35-77d8-2b75-948a-002fb1547b00@intel.com> (raw)
In-Reply-To: <19281916.JWhrcDiPUG@xps>

On 6/28/2019 10:57 AM, Thomas Monjalon wrote:
> 28/06/2019 11:55, Ferruh Yigit:
>> On 6/28/2019 10:17 AM, Thomas Monjalon wrote:
>>> 28/06/2019 10:46, Laatz, Kevin:
>>>>
>>>> On 27/06/2019 20:51, Ferruh Yigit wrote:
>>>>> Build error:
>>>>> ../lib/librte_telemetry/rte_telemetry.c:558:28:
>>>>>    error: comparison of unsigned expression < 0 is always false
>>>>>    [-Werror,-Wtautological-compare]
>>>>>
>>>>> Build error not observed in default make build because telemetry library
>>>>> disabled by default but easier to reproduce via meson.
>>>
>>> No, I compile telemetry with make and with meson.
>>> I cannot reproduce the error. I guess it depends of the compiler version?
>>
>> At least I am seeing this via clang 4.0.1
> 
> clang version 8.0.0 here.
> Go update your machine :)
> 

But I believe the warning is valid, no idea why clang 8 is not warning


      reply	other threads:[~2019-06-28 10:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 19:51 [dpdk-stable] " Ferruh Yigit
2019-06-28  8:46 ` Laatz, Kevin
2019-06-28  9:17   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-06-28  9:55     ` Ferruh Yigit
2019-06-28  9:57       ` Thomas Monjalon
2019-06-28 10:28         ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7808db35-77d8-2b75-948a-002fb1547b00@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=flavia.musatescu@intel.com \
    --cc=kevin.laatz@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).