From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx: fix compile errors with ignore pedantic pragma
Date: Fri, 30 Sep 2016 15:33:00 +0100 [thread overview]
Message-ID: <78fe6c4a-b57a-a4e5-5317-29d4b1238023@intel.com> (raw)
In-Reply-To: <20160920181751.GJ17252@6wind.com>
On 9/20/2016 7:17 PM, Adrien Mazarguil wrote:
> On Tue, Sep 20, 2016 at 04:58:48PM +0100, Bruce Richardson wrote:
>> On Tue, Sep 20, 2016 at 02:51:27PM +0200, Adrien Mazarguil wrote:
>>> On Mon, Sep 19, 2016 at 04:26:05PM +0100, Bruce Richardson wrote:
>>>> On Mon, Sep 19, 2016 at 04:59:59PM +0200, Adrien Mazarguil wrote:
>>>>> Hi Bruce,
>>>>>
>>>>> On Mon, Sep 19, 2016 at 03:36:54PM +0100, Bruce Richardson wrote:
>>>>>> With recent gcc versions, e.g. gcc 6.1, compilation of mlx drivers with
>>>>>> debug enabled produces lots of errors complaining that "pedantic" is
>>>>>> not a warning level that can be ignored.
>>>>>>
>>>>>> error: ‘-pedantic’ is not an option that controls warnings [-Werror=pragmas]
>>>>>> #pragma GCC diagnostic ignored "-pedantic"
>>>>>> ^~~~~~~~~~~
>>>>>>
>>>>>> These errors can be removed by changing the "-pedantic" to "-Wpedantic".
>>>>>
>>>>> Nice to have a workaround, I thought they did not keep the option at all.
>>>>> However after testing:
>>>>>
>>>>> - It does not seem to work with GCC 4.6 and older, they prefer -pedantic:
>>>>> "warning: unknown option after `#pragma GCC diagnostic' kind".
>>>>>
>>>>> - GCC 4.9 (possibly 5.x as well) does not care, can use either -pedantic or
>>>>> -Wpedantic.
>>>>>
>>>>> - GCC 6 can only supports -Wpedantic.
>>>>>
>>>>> Note we're working toward removing the need for these #pragma in the first
>>>>> place as soon as possible, however in the meantime I fear that checking the
>>>>> GCC version is necessary.
>>>>>
>>>> Depends on how old of GCC version we need to support. From the release notes
>>>> it appears that -Wpedantic was introduced in GCC 4.8 (3 1/2 years ago).
>>>>
>>>> https://gcc.gnu.org/gcc-4.8/changes.html
>>>>
>>>> Do we need to support compilation on gcc versions older than this?
>>>
>>> I'm all for upgrading so I do not really mind if we stop caring about older
>>> GCC versions (especially considering this problem only occurs in debugging
>>> mode which is seldom used by non-developers). The version check is necessary
>>> if we want to keep full compatibility with at least:
>>>
>>> - RHEL <= 6.x
>>> - Debian <= 7.x
>>> - Ubuntu <= 13.04
>>>
>>> Works for me either way, thus:
>>>
>>> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>>
>> Any objections to dropping of support for debug settings for these OS's?
>
> Not sure who should answer this. These #pragma are workarounds we should
> eventually get rid of anyway (DPDK headers are now clean enough, some work
> remains to be done on the Verbs side) so let's use your patch in the
> meantime.
>
Just as a quick note, this breaks compilation for ICC:
.../drivers/net/mlx4/mlx4.c(64): error #2282: unrecognized GCC pragma
#pragma GCC diagnostic ignored "-Wpedantic"
Since this compilation error only happens for MLX4/5 when debug config
option enabled, this not big issue, but please aware of the issue.
Thanks,
ferruh
next prev parent reply other threads:[~2016-09-30 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 14:36 Bruce Richardson
2016-09-19 14:59 ` Adrien Mazarguil
2016-09-19 15:26 ` Bruce Richardson
2016-09-20 12:51 ` Adrien Mazarguil
2016-09-20 15:58 ` Bruce Richardson
2016-09-20 18:17 ` Adrien Mazarguil
2016-09-30 14:33 ` Ferruh Yigit [this message]
2016-09-21 5:11 ` Panu Matilainen
2016-09-21 9:48 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78fe6c4a-b57a-a4e5-5317-29d4b1238023@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).