From: Yong Wang <yongwang@vmware.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>, Yong Wang <yongwang@vmware.com>
Subject: Re: [dpdk-dev] [PATCH] vmxnet3: remove 0x prefix for %p format
Date: Thu, 23 Jun 2016 13:45:43 -0700 [thread overview]
Message-ID: <792D9F5D-8D79-4D3A-B2D1-349A8F0B50B2@vmware.com> (raw)
In-Reply-To: <1466679174-6538-1-git-send-email-ferruh.yigit@intel.com>
> On Jun 23, 2016, at 3:52 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> To prevent double 0x in logs
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> —
Acked-by: Yong Wang <yongwang@vmware.com>
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index ccafc0c..1e0fde0 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -96,7 +96,7 @@ vmxnet3_rxq_dump(struct vmxnet3_rx_queue *rxq)
> return;
>
> PMD_RX_LOG(DEBUG,
> - "RXQ: cmd0 base : 0x%p cmd1 base : 0x%p comp ring base : 0x%p.",
> + "RXQ: cmd0 base : %p cmd1 base : %p comp ring base : %p.",
> rxq->cmd_ring[0].base, rxq->cmd_ring[1].base, rxq->comp_ring.base);
> PMD_RX_LOG(DEBUG,
> "RXQ: cmd0 basePA : 0x%lx cmd1 basePA : 0x%lx comp ring basePA : 0x%lx.",
> @@ -126,7 +126,7 @@ vmxnet3_txq_dump(struct vmxnet3_tx_queue *txq)
> if (txq == NULL)
> return;
>
> - PMD_TX_LOG(DEBUG, "TXQ: cmd base : 0x%p comp ring base : 0x%p data ring base : 0x%p.",
> + PMD_TX_LOG(DEBUG, "TXQ: cmd base : %p comp ring base : %p data ring base : %p.",
> txq->cmd_ring.base, txq->comp_ring.base, txq->data_ring.base);
> PMD_TX_LOG(DEBUG, "TXQ: cmd basePA : 0x%lx comp ring basePA : 0x%lx data ring basePA : 0x%lx.",
> (unsigned long)txq->cmd_ring.basePA,
> --
> 2.5.5
>
next prev parent reply other threads:[~2016-06-23 20:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 10:44 [dpdk-dev] PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings Simon Kagstrom
2016-06-20 16:19 ` Stephen Hemminger
2016-06-21 13:11 ` Ferruh Yigit
2016-06-22 7:08 ` Simon Kågström
2016-06-23 10:52 ` [dpdk-dev] [PATCH] vmxnet3: remove 0x prefix for %p format Ferruh Yigit
2016-06-23 20:45 ` Yong Wang [this message]
2016-06-24 16:44 ` Bruce Richardson
2016-06-23 10:58 ` [dpdk-dev] PATCH] mbuf: rte_pktmbuf_dump: don't add 0x when using %p in format strings Ferruh Yigit
2016-06-23 21:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=792D9F5D-8D79-4D3A-B2D1-349A8F0B50B2@vmware.com \
--to=yongwang@vmware.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).