From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Harton <dharton@cisco.com>,
mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com,
evgenys@amazon.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ena: fix init of ena pci_dev info
Date: Wed, 23 Aug 2017 11:47:30 +0100 [thread overview]
Message-ID: <79655ab0-8e8f-b9b2-51bd-af50fc783604@intel.com> (raw)
In-Reply-To: <20170823004145.29046-1-dharton@cisco.com>
On 8/23/2017 1:41 AM, David Harton wrote:
> eth_ena_dev_init() was not initializing all of the common
> pci dev info for the rte_eth_dev. Added call to
> rte_eth_copy_pci_info() to complete the init particularly
> the driver name.
rte_eth_copy_pci_info() already called during probe [1], what
information was missing?
[1]
eth_ena_pci_probe()
rte_eth_dev_pci_generic_probe()
rte_eth_dev_pci_allocate()
rte_eth_copy_pci_info() <---
eth_ena_dev_init()
... <--- where rte_eth_copy_pci_info() added again.
>
> Signed-off-by: David Harton <dharton@cisco.com>
> ---
> drivers/net/ena/ena_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 80ce1f3..a6c408b 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -1289,6 +1289,7 @@ static int eth_ena_dev_init(struct rte_eth_dev *eth_dev)
> return 0;
>
> pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev);
> + rte_eth_copy_pci_info(eth_dev, pci_dev);
> adapter->pdev = pci_dev;
>
> PMD_INIT_LOG(INFO, "Initializing %x:%x:%x.%d",
>
next prev parent reply other threads:[~2017-08-23 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 0:41 David Harton
2017-08-23 5:51 ` Michał Krawczyk
2017-08-23 10:47 ` Ferruh Yigit [this message]
2017-08-23 13:20 ` David Harton (dharton)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79655ab0-8e8f-b9b2-51bd-af50fc783604@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=dharton@cisco.com \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).