From: "Mrzyglod, DanielX T" <danielx.t.mrzyglod@intel.com>
To: "Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8
Date: Wed, 22 Jun 2016 08:45:06 +0000 [thread overview]
Message-ID: <7ADD74816B4C8A45B56203CBA65FE5A6377962B4@IRSMSX107.ger.corp.intel.com> (raw)
In-Reply-To: <1466501740-28237-1-git-send-email-danielx.t.mrzyglod@intel.com>
>From: Mrzyglod, DanielX T
>Sent: Tuesday, June 21, 2016 11:36 AM
>To: Singh, Jasvinder <jasvinder.singh@intel.com>; Dumitrescu, Cristian
><cristian.dumitrescu@intel.com>
>Cc: dev@dpdk.org; Mrzyglod, DanielX T <danielx.t.mrzyglod@intel.com>
>Subject: [PATCH v2] examples/ip_pipeline: fix build error for gcc 4.8
>
>This patch fixes a maybe-uninitialized warning when compiling DPDK with GCC 4.8
>
>examples/ip_pipeline/pipeline/pipeline_common_fe.c: In function
>'app_pipeline_track_pktq_out_to_link':
>examples/ip_pipeline/pipeline/pipeline_common_fe.c:66:31: error:
>'reader' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>
> struct app_pktq_out_params *pktq_out =
>
>Fixes: 760064838ec0 ("examples/ip_pipeline: link routing output ports to
>devices")
>
>Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>---
> examples/ip_pipeline/app.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/examples/ip_pipeline/app.h b/examples/ip_pipeline/app.h
>index 7611341..242dae8 100644
>--- a/examples/ip_pipeline/app.h
>+++ b/examples/ip_pipeline/app.h
>@@ -667,11 +667,11 @@ app_swq_get_reader(struct app_params *app,
> struct app_pktq_swq_params *swq,
> uint32_t *pktq_in_id)
> {
>- struct app_pipeline_params *reader;
>+ struct app_pipeline_params *reader = NULL;
> uint32_t pos = swq - app->swq_params;
> uint32_t n_pipelines = RTE_MIN(app->n_pipelines,
> RTE_DIM(app->pipeline_params));
>- uint32_t n_readers = 0, id, i;
>+ uint32_t n_readers = 0, id = 0, i;
>
> for (i = 0; i < n_pipelines; i++) {
> struct app_pipeline_params *p = &app->pipeline_params[i];
>@@ -727,11 +727,11 @@ app_tm_get_reader(struct app_params *app,
> struct app_pktq_tm_params *tm,
> uint32_t *pktq_in_id)
> {
>- struct app_pipeline_params *reader;
>+ struct app_pipeline_params *reader = NULL;
> uint32_t pos = tm - app->tm_params;
> uint32_t n_pipelines = RTE_MIN(app->n_pipelines,
> RTE_DIM(app->pipeline_params));
>- uint32_t n_readers = 0, id, i;
>+ uint32_t n_readers = 0, id = 0, i;
>
> for (i = 0; i < n_pipelines; i++) {
> struct app_pipeline_params *p = &app->pipeline_params[i];
>--
>2.5.5
Self-NACK already applied
prev parent reply other threads:[~2016-06-22 8:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 11:38 [dpdk-dev] [PATCH] " Daniel Mrzyglod
2016-06-09 10:52 ` Dumitrescu, Cristian
2016-06-14 19:04 ` Thomas Monjalon
2016-06-16 13:35 ` Jastrzebski, MichalX K
2016-06-21 9:35 ` [dpdk-dev] [PATCH v2] " Daniel Mrzyglod
2016-06-21 17:43 ` Dumitrescu, Cristian
2016-06-22 8:44 ` Mrzyglod, DanielX T
2016-06-22 8:45 ` Mrzyglod, DanielX T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ADD74816B4C8A45B56203CBA65FE5A6377962B4@IRSMSX107.ger.corp.intel.com \
--to=danielx.t.mrzyglod@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).