From: Ilya Matveychikov <matvejchikov@gmail.com>
To: "Hanoch Haim (hhaim)" <hhaim@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), remove useless variable
Date: Wed, 15 Nov 2017 00:50:58 +0400 [thread overview]
Message-ID: <7CC49471-2114-4742-8C66-2CF286DE2CF2@gmail.com> (raw)
In-Reply-To: <c09a80d037c2438f9fb4dc5c012a4b4d@XCH-RTP-017.cisco.com>
> On Nov 15, 2017, at 12:32 AM, Hanoch Haim (hhaim) <hhaim@cisco.com> wrote:
>
> I would add this too
>
> - } else if (rte_atomic16_add_return(&m->refcnt_atomic, -1) == 0)
>
> Should be :
>
> + } else if (likely(rte_mbuf_refcnt_update(m, -1) == 0)) {
>
>
> Hanoh
>
Why not to send the separate patch for the change?
next prev parent reply other threads:[~2017-11-14 20:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 13:44 Ilya Matveychikov
2017-11-14 20:32 ` Hanoch Haim (hhaim)
2017-11-14 20:50 ` Ilya Matveychikov [this message]
2017-12-01 16:36 ` Olivier MATZ
2017-12-09 21:08 ` [dpdk-dev] [PATCH v2] mbuf: cleanup rte_pktmbuf_lastseg function Ilya V. Matveychikov
2017-12-14 8:48 ` Olivier MATZ
2017-12-14 9:30 ` Olivier MATZ
2018-01-11 23:21 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7CC49471-2114-4742-8C66-2CF286DE2CF2@gmail.com \
--to=matvejchikov@gmail.com \
--cc=dev@dpdk.org \
--cc=hhaim@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).