From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] mem: warn user when running without NUMA support
Date: Wed, 27 Mar 2019 11:52:13 +0000 [thread overview]
Message-ID: <7a0681ab-b71d-9a43-e4de-4827bed69ccc@intel.com> (raw)
In-Reply-To: <10158735.WBPJjXTH6e@xps>
On 27-Mar-19 10:31 AM, Thomas Monjalon wrote:
> 22/02/2019 16:59, Anatoly Burakov:
>> Running in non-legacy mode on a NUMA-enabled system without libnuma
>> is unsupported, so explicitly print out a warning when trying to
>> do so.
>>
>> Running in legacy mode without libnuma is still supported whether or
>> not we are running with libnuma support enabled, so also fix init to
>> allow that scenario.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
>> @@ -50,6 +50,7 @@
>> #include "eal_internal_cfg.h"
>> #include "eal_filesystem.h"
>> #include "eal_hugepages.h"
>> +#include "eal_options.h"
>
> I'm seeing this error:
>
> lib/librte_eal/common/eal_options.h:74:28: error:
> array type has incomplete element type ‘struct option’
> extern const struct option eal_long_options[];
>
Yes, i've been meaning to resubmit but it fell through the cracks. I'll
do a v2 ASAP.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-03-27 11:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 15:59 [dpdk-stable] " Anatoly Burakov
2019-03-27 10:31 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-03-27 11:52 ` Burakov, Anatoly [this message]
2019-03-27 13:35 ` [dpdk-stable] [PATCH v2] " Anatoly Burakov
2019-03-28 20:29 ` Thomas Monjalon
2019-03-29 12:30 ` [dpdk-stable] [PATCH v3] " Anatoly Burakov
2019-03-29 12:43 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-03-29 14:01 ` [dpdk-stable] [PATCH v4] " Anatoly Burakov
2019-03-29 23:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a0681ab-b71d-9a43-e4de-4827bed69ccc@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).