From: "Gao Feng" <gfree.wind@vip.163.com>
To: "Thomas Monjalon" <thomas@monjalon.net>
Cc: "Gao Feng" <davidfgao@tencent.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: fix unlock in rte_eal_memzone_init
Date: Thu, 20 Dec 2018 19:47:12 +0800 (CST) [thread overview]
Message-ID: <7a20530c.19679d.167cb70e214.Coremail.gfree.wind@vip.163.com> (raw)
In-Reply-To: <2129438.97vpQxbemm@xps>
At 2018-12-20 19:36:14, "Thomas Monjalon" <thomas@monjalon.net> wrote:
>20/12/2018 12:20, Thomas Monjalon:
>> 07/12/2018 09:57, Burakov, Anatoly:
>> > On 07-Dec-18 1:20 AM, Gao Feng wrote:
>> > > The RTE_PROC_PRIMARY error handler lost the unlock statement in the
>> > > current codes. Now unlock and return in one place to fix it.
>> > >
>> > > Fixes: 49df3db84883 ("memzone: replace memzone array with fbarray")
>> > > Cc: stable@dpdk.org
>> > >
>> > > Signed-off-by: Gao Feng <davidfgao@tencent.com>
>> > > ---
>> > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>
>> Applied, thanks
>>
>> I changed your author email (From:) to match the Signed-off-by one.
>> Please configure your git to use the Tencent email if possible.
>> Note you can have a "git From" address and use another one for sending.
>
>One more tip about patch formatting:
>
>I reworded the title to:
> memzone: fix unlock on initialization failure
>
>The prefix "memzone" gives the scope of the change.
>We decided that memzone is important enough to have its own scope prefix.
>You can find other prefixes in the git history.
>
>Then the rest of the title is written in plain english,
>detailing more the scope with "on initialization failure".
>
>Hope it helps, and welcome :)
Thanks your enhancement, I think it's better.
Best Regards
Feng
>
>
next prev parent reply other threads:[~2018-12-20 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 0:47 [dpdk-dev] [PATCH] " gfree.wind
2018-12-06 9:09 ` Burakov, Anatoly
2018-12-06 9:44 ` Gao Feng
2018-12-06 11:18 ` Burakov, Anatoly
2018-12-07 1:20 ` [dpdk-dev] [PATCH v2] " Gao Feng
2018-12-07 8:57 ` Burakov, Anatoly
2018-12-20 11:20 ` Thomas Monjalon
2018-12-20 11:36 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-12-20 11:47 ` Gao Feng [this message]
2018-12-20 11:44 ` [dpdk-dev] " Gao Feng
2018-12-20 13:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a20530c.19679d.167cb70e214.Coremail.gfree.wind@vip.163.com \
--to=gfree.wind@vip.163.com \
--cc=anatoly.burakov@intel.com \
--cc=davidfgao@tencent.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).