From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Alejandro Lucero <alejandro.lucero@netronome.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: fix error handling logic
Date: Mon, 24 Sep 2018 17:10:02 +0300 [thread overview]
Message-ID: <7a20a3f2-bf64-31d8-1ced-b92fcd204f30@solarflare.com> (raw)
In-Reply-To: <1537796604-29378-1-git-send-email-alejandro.lucero@netronome.com>
On 9/24/18 4:43 PM, Alejandro Lucero wrote:
> This patch fixes how function exit is handled when errors inside
> rte_eth_dev_create.
>
> Fixes: e489007a411c ("ethdev: add generic create/destroy ethdev APIs")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Minor nit/observation below, but anyway
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> lib/librte_ethdev/rte_ethdev.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
> index aa7730c..ef99f70 100644
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> @@ -3467,10 +3467,8 @@ int rte_eth_set_queue_rate_limit(uint16_t port_id, uint16_t queue_idx,
>
> if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
> ethdev = rte_eth_dev_allocate(name);
> - if (!ethdev) {
> - retval = -ENODEV;
> - goto probe_failed;
> - }
> + if (!ethdev)
> + return -ENODEV;
As far as I can see rte_eth_dev_allocate() returns NULL if a device
with such name already exists or no free ports left. I'd say that
EEXIST and ENOSPC better describe what went wrong, but the patch
simply does not change it and there is no easy way to fix it
(except may be rte_errno usage).
>
> if (priv_data_size) {
> ethdev->data->dev_private = rte_zmalloc_socket(
> @@ -3480,7 +3478,7 @@ int rte_eth_set_queue_rate_limit(uint16_t port_id, uint16_t queue_idx,
> if (!ethdev->data->dev_private) {
> RTE_LOG(ERR, EAL, "failed to allocate private data");
> retval = -ENOMEM;
> - goto probe_failed;
> + goto data_alloc_failed;
> }
> }
> } else {
> @@ -3488,8 +3486,7 @@ int rte_eth_set_queue_rate_limit(uint16_t port_id, uint16_t queue_idx,
> if (!ethdev) {
> RTE_LOG(ERR, EAL, "secondary process attach failed, "
> "ethdev doesn't exist");
> - retval = -ENODEV;
> - goto probe_failed;
> + return -ENODEV;
Here ENODEV is 100% correct since secondary simply failed to find
ethdev with matching name.
> }
> }
>
> @@ -3518,6 +3515,7 @@ int rte_eth_set_queue_rate_limit(uint16_t port_id, uint16_t queue_idx,
> if (rte_eal_process_type() == RTE_PROC_PRIMARY)
> rte_free(ethdev->data->dev_private);
>
> +data_alloc_failed:
> rte_eth_dev_release_port(ethdev);
>
> return retval;
next prev parent reply other threads:[~2018-09-24 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 13:43 [dpdk-stable] " Alejandro Lucero
2018-09-24 14:10 ` Andrew Rybchenko [this message]
2018-09-25 14:12 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a20a3f2-bf64-31d8-1ced-b92fcd204f30@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=alejandro.lucero@netronome.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).