From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, jfreimann@redhat.com, tiwei.bie@intel.com,
zhihong.wang@intel.com
Subject: Re: [dpdk-dev] [PATCH 2/3] net/virtio: merge Rx mergeable and non-mergeable paths
Date: Fri, 7 Dec 2018 17:15:39 +0100 [thread overview]
Message-ID: <7b39a9cb-9799-e1d7-f3f9-4b29fe1627a2@redhat.com> (raw)
In-Reply-To: <20181203151036.11293-3-maxime.coquelin@redhat.com>
On 12/3/18 4:10 PM, Maxime Coquelin wrote:
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> drivers/net/virtio/virtio_ethdev.c | 5 --
> drivers/net/virtio/virtio_ethdev.h | 3 -
> drivers/net/virtio/virtio_rxtx.c | 115 ++---------------------------
> 3 files changed, 7 insertions(+), 116 deletions(-)
Intel STV team ran more tests and found a performance regression.
I managed to reproduce it, and worked on optimizing the Rx path.
I managed to go from -25% to -6% for this use case, but this is still a
significant regression so I'll drop this patch.
The good news is that the optimization is valid for mergeable buffers
case, and it gains 5% so I'll post this optimization instead.
Thanks to the STV team for the testing,
Maxime
next prev parent reply other threads:[~2018-12-07 16:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 15:10 [dpdk-dev] [PATCH 0/3] net/virtio: Rx paths cleanup Maxime Coquelin
2018-12-03 15:10 ` [dpdk-dev] [PATCH 1/3] net/virtio: inline refill and offload helpers Maxime Coquelin
2018-12-03 15:10 ` [dpdk-dev] [PATCH 2/3] net/virtio: merge Rx mergeable and non-mergeable paths Maxime Coquelin
2018-12-07 16:15 ` Maxime Coquelin [this message]
2018-12-03 15:10 ` [dpdk-dev] [PATCH 3/3] net/virtio: add non-mergeable support to in-order path Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b39a9cb-9799-e1d7-f3f9-4b29fe1627a2@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jfreimann@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).