From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>
Cc: David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 0/2] Mark shared pthread mutex
Date: Fri, 16 Apr 2021 09:25:17 +0100 [thread overview]
Message-ID: <7b7ea4a4-b1a2-aaa7-f114-49d435fe3fc2@intel.com> (raw)
In-Reply-To: <20210316092805.0168dfb7@hermes.local>
On 3/16/2021 4:28 PM, Stephen Hemminger wrote:
> On Mon, 15 Mar 2021 12:27:20 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>
>> This fixes two places where pthread_mutex was being unsafely
>> used between primary secondary process.
>>
>> These patches are necessary but not sufficient to address Bug 662
>>
>> Stephen Hemminger (2):
>> ethdev: make flow API primary/secondary process safe
>> net/failsafe: fix primary/secondary mutex
>>
>> drivers/net/failsafe/failsafe.c | 5 +++++
>> lib/librte_ethdev/rte_ethdev.c | 6 +++++-
>> 2 files changed, 10 insertions(+), 1 deletion(-)
>>
>
> The following drivers have the same kind of issue.
>
> Drivers with unsafe pthread_mutex:
>
> net/
> af_xdp
> atlantic
> axgbe
> bnxt
> ena
> failsafe (see patch #2)
> hinic
> mlx5
> qede
> vhost
> virtio
>
> raw/
> ifpga
> vdpa/
> ifc
> mlx5
>
>
> Another alternative would be to create a DPDK wrapper (rte_mutex?)
> which had the proper semantics. That might make the Windows port easier.
> But it would make backport to stable harder.
>
>
> If this does not get fixed in April, we should change documentation
> to warn users.
>
>
+Anatoly as our multi process maintainer.
And most of the above nics already doesn't claim the multi process support (in
.ini files), the ones that claims the support:
mlx[45]
bnxt
hinic
qede
virtio
prev parent reply other threads:[~2021-04-16 8:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 19:27 Stephen Hemminger
2021-03-15 19:27 ` [dpdk-dev] [PATCH 1/2] ethdev: make flow API primary/secondary process safe Stephen Hemminger
2021-03-16 23:48 ` Suanming Mou
2021-03-17 0:13 ` Stephen Hemminger
2021-03-17 0:32 ` Suanming Mou
2021-04-14 13:06 ` Ferruh Yigit
2021-04-15 2:55 ` Suanming Mou
2021-04-15 3:17 ` Stephen Hemminger
2021-04-15 7:42 ` Ferruh Yigit
2021-04-15 20:04 ` Stephen Hemminger
2021-04-16 0:57 ` Suanming Mou
2021-04-16 3:19 ` Ajit Khaparde
2021-04-16 1:41 ` fengchengwen
2021-04-16 8:12 ` Ferruh Yigit
2021-04-16 8:18 ` Ferruh Yigit
2021-04-19 17:14 ` Thomas Monjalon
2021-04-19 17:45 ` Stephen Hemminger
2021-04-19 18:09 ` Thomas Monjalon
2021-06-08 8:07 ` Andrew Rybchenko
2021-03-15 19:27 ` [dpdk-dev] [PATCH 2/2] net/failsafe: fix primary/secondary mutex Stephen Hemminger
2021-04-14 13:10 ` Ferruh Yigit
2021-04-16 8:19 ` Ferruh Yigit
2021-04-19 17:08 ` Thomas Monjalon
2021-06-08 8:00 ` Andrew Rybchenko
2021-06-08 15:42 ` Stephen Hemminger
2021-06-08 15:55 ` Andrew Rybchenko
2021-06-08 20:48 ` Stephen Hemminger
2021-06-09 10:04 ` Andrew Rybchenko
2021-06-14 14:43 ` Gaëtan Rivet
2022-10-17 10:40 ` [External] : " Madhuker Mythri
2021-03-15 19:45 ` [dpdk-dev] [PATCH 0/2] Mark shared pthread mutex Stephen Hemminger
2021-03-16 16:28 ` Stephen Hemminger
2021-04-16 8:25 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b7ea4a4-b1a2-aaa7-f114-49d435fe3fc2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).