DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Hunt, David" <david.hunt@intel.com>
To: Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] examples/power: add turbo commands to help text
Date: Thu, 19 Oct 2017 13:27:11 +0100	[thread overview]
Message-ID: <7bfbbc7e-20c5-c17c-d410-c176ff76e21d@intel.com> (raw)
In-Reply-To: <1508405665-232195-1-git-send-email-marko.kovacevic@intel.com>

Hi Marko,

On 19/10/2017 10:34 AM, Marko Kovacevic wrote:
> From: David Hunt <david.hunt@intel.com>
>
> Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI")
>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
>   examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> index dc9efc2..63f711e 100644
> --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> @@ -131,8 +131,9 @@ cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd =
>   cmdline_parse_inst_t cmd_set_cpu_freq_set = {
>   	.f = cmd_set_cpu_freq_parsed,
>   	.data = NULL,
> -	.help_str = "set_cpu_freq <core_num> <up|down|min|max>, Set the current "
> -			"frequency for the specified core by scaling up/down/min/max",
> +	.help_str = "set_cpu_freq <core_num> "
> +			"<up|down|min|max|enable_turbo|disable_turbo>, "
> +			"adjust the frequency for the specified core.",
>   	.tokens = {
>   		(void *)&cmd_set_cpu_freq,
>   		(void *)&cmd_set_cpu_freq_core_num,

Thanks for the patch. Looks good to me.

Acked-by: David Hunt <david.hunt@intel.com>

  reply	other threads:[~2017-10-19 12:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-19  9:34 Marko Kovacevic
2017-10-19 12:27 ` Hunt, David [this message]
2017-10-24 21:51   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7bfbbc7e-20c5-c17c-d410-c176ff76e21d@intel.com \
    --to=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=marko.kovacevic@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).