From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>, dev@dpdk.org
Cc: benjamin.walker@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] eal/linux: fix multi-process cannot work
Date: Wed, 29 Mar 2017 16:19:15 +0100 [thread overview]
Message-ID: <7c01afcd-20a7-f2a0-f230-04e5b04fb3c9@intel.com> (raw)
In-Reply-To: <1489681724-22114-1-git-send-email-jianfeng.tan@intel.com>
On 16/03/2017 16:28, Jianfeng Tan wrote:
> When binding with vfio-pci, secondary process cannot be started with
> an error message:
>
> cannot find TAILQ entry for PCI device.
>
> It's due to: struct rte_pci_addr is padded with 1 byte for alignment
> by compiler. Then below comparison in commit 2f4adfad0a69
> ("vfio: add multiprocess support") will fail if the last byte is not
> initialized.
>
> memcmp(&vfio_res->pci_addr, &dev->addr, sizeof(dev->addr)
>
> And commit cdc242f260e7 ("eal/linux: support running as unprivileged user")
> just triggers this bug by using a stack un-initialized variable.
>
> The fix is to use rte_eal_compare_pci_addr() for pci addr comparison.
>
> Fixes: 2f4adfad0a69 ("vfio: add multiprocess support")
> Fixes: cdc242f260e7 ("eal/linux: support running as unprivileged user")
> CC: stable@dpdk.org
>
> Reported-by: Rutkowski, Pawel <pawelx.rutkowski@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
> lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> index 5f478c5..7d8b9fb 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> @@ -355,7 +355,8 @@ pci_vfio_map_resource(struct rte_pci_device *dev)
> } else {
> /* if we're in a secondary process, just find our tailq entry */
> TAILQ_FOREACH(vfio_res, vfio_res_list, next) {
> - if (memcmp(&vfio_res->pci_addr, &dev->addr, sizeof(dev->addr)))
> + if (rte_eal_compare_pci_addr(&vfio_res->pci_addr,
> + &dev->addr))
> continue;
> break;
> }
Acked-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
next prev parent reply other threads:[~2017-03-29 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 16:28 Jianfeng Tan
2017-03-29 15:19 ` Sergio Gonzalez Monroy [this message]
2017-04-04 9:58 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c01afcd-20a7-f2a0-f230-04e5b04fb3c9@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=benjamin.walker@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).