From: Akhil Goyal <akhil.goyal@nxp.com>
To: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>, dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG
Date: Thu, 21 Jun 2018 19:42:50 +0530 [thread overview]
Message-ID: <7c8dc199-9d02-e23a-05e1-0f0666149275@nxp.com> (raw)
In-Reply-To: <32f96244-0b7f-17ff-9cc0-8e8955b8904e@nxp.com>
Please remove lib from subject also.
On 6/21/2018 7:41 PM, Akhil Goyal wrote:
> Hi Jananee,
>
>
> On 6/12/2018 12:08 PM, Jananee Parthasarathy wrote:
>> For librte_cryptodev dynamic logging,
>> conditional compilation of debug logs would not be required anymore.
>
> I believe this shall also be removed from config/common_base and
> lib/librte_eal/common/include/rte_dev.h as nobody is using it.
>
> -Akhil
>
>>
>> Signed-off-by: Jananee Parthasarathy
>> <jananeex.m.parthasarathy@intel.com>
>> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
>> ---
>> lib/librte_cryptodev/rte_cryptodev.h | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
>> b/lib/librte_cryptodev/rte_cryptodev.h
>> index 92ce6d49a..229712ebf 100644
>> --- a/lib/librte_cryptodev/rte_cryptodev.h
>> +++ b/lib/librte_cryptodev/rte_cryptodev.h
>> @@ -65,7 +65,6 @@ extern const char **rte_cyptodev_names;
>> RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
>> RTE_FMT_TAIL(__VA_ARGS__,)))
>> -#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG
>> #define CDEV_LOG_DEBUG(...) \
>> RTE_LOG(DEBUG, CRYPTODEV, \
>> RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
>> @@ -76,13 +75,6 @@ extern const char **rte_cyptodev_names;
>> RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
>> dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
>> -#else
>> -#define CDEV_LOG_DEBUG(...) (void)0
>> -#define CDEV_PMD_TRACE(...) (void)0
>> -#endif
>> -
>> -
>> -
>> /**
>> * A macro that points to an offset from the start
>> * of the crypto operation structure (rte_crypto_op)
>
next prev parent reply other threads:[~2018-06-21 14:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 6:38 Jananee Parthasarathy
2018-06-21 14:11 ` Akhil Goyal
2018-06-21 14:12 ` Akhil Goyal [this message]
2018-06-27 16:36 ` De Lara Guarch, Pablo
2018-07-02 12:30 ` [dpdk-dev] [PATCH v2] cryptodev: " Jananee Parthasarathy
2018-07-02 15:51 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c8dc199-9d02-e23a-05e1-0f0666149275@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).