From: santosh <santosh.shukla@caviumnetworks.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, olivier.matz@6wind.com
Cc: dev@dpdk.org, shreyansh.jain@nxp.com
Subject: Re: [dpdk-dev] [PATCH v3 1/2] test/test: free mempool on exit
Date: Tue, 4 Apr 2017 20:58:35 +0530 [thread overview]
Message-ID: <7c94f0ff-e73c-17c0-eba4-3f12b537a07e@caviumnetworks.com> (raw)
In-Reply-To: <1491285429-1114-1-git-send-email-hemant.agrawal@nxp.com>
Hi Hemant,
[Noticed that my first reply couldn't reach out to ML so re-sending]
On Tuesday 04 April 2017 11:27 AM, Hemant Agrawal wrote:
> From: Shreyansh Jain <shreyansh.jain@nxp.com>
>
> mempool autotest was not freeing the mempools.
>
> Fixes: 8ef772ae ("app/test: rework mempool tes")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> ---
> v3: fix the incorrect split
> v2: separte the bug fix from change
>
> test/test/test_mempool.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> diff --git a/test/test/test_mempool.c b/test/test/test_mempool.c
> index b9880b3..715b250 100644
> --- a/test/test/test_mempool.c
> +++ b/test/test/test_mempool.c
> @@ -509,6 +509,7 @@ static int test_mempool_single_consumer(void)
> static int
> test_mempool(void)
> {
> + int ret = -1;
> struct rte_mempool *mp_cache = NULL;
> struct rte_mempool *mp_nocache = NULL;
> struct rte_mempool *mp_stack = NULL;
> @@ -607,13 +608,13 @@ static int test_mempool_single_consumer(void)
>
> rte_mempool_list_dump(stdout);
>
> - return 0;
> + ret = 0;
>
> err:
> rte_mempool_free(mp_nocache);
> rte_mempool_free(mp_cache);
> rte_mempool_free(mp_stack);
> - return -1;
> + return ret;
> }
>
> REGISTER_TEST_COMMAND(mempool_autotest, test_mempool);
next prev parent reply other threads:[~2017-04-04 15:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 10:17 [dpdk-dev] [RFC PATCH] test/test: support default mempool autotest Shreyansh Jain
2017-03-31 13:59 ` Olivier Matz
2017-03-31 14:11 ` Hemant Agrawal
2017-03-31 15:11 ` Santosh Shukla
2017-04-03 9:27 ` Hemant Agrawal
2017-04-03 9:00 ` [dpdk-dev] [PATCH v2 1/2] test/test: free mempool on exit Hemant Agrawal
2017-04-03 9:00 ` [dpdk-dev] [PATCH v2 2/2] test/test: support default mempool autotest Hemant Agrawal
2017-04-04 5:57 ` [dpdk-dev] [PATCH v3 1/2] test/test: free mempool on exit Hemant Agrawal
2017-04-04 5:57 ` [dpdk-dev] [PATCH v3 2/2] test/test: support default mempool autotest Hemant Agrawal
2017-04-05 7:02 ` santosh
2017-04-05 7:21 ` Shreyansh Jain
2017-04-04 15:28 ` santosh [this message]
2017-04-05 9:35 ` [dpdk-dev] [PATCH v4 1/2] test/test: free mempool on exit Shreyansh Jain
2017-04-05 9:35 ` [dpdk-dev] [PATCH v4 2/2] test/test: support default mempool autotest Shreyansh Jain
2017-04-07 15:42 ` Olivier Matz
2017-04-19 13:10 ` Thomas Monjalon
2017-04-07 15:42 ` [dpdk-dev] [PATCH v4 1/2] test/test: free mempool on exit Olivier Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c94f0ff-e73c-17c0-eba4-3f12b537a07e@caviumnetworks.com \
--to=santosh.shukla@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).