From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Cc: Scott Branden <scott.branden@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: convert to SPDX license tag
Date: Fri, 30 Mar 2018 11:35:54 +0100 [thread overview]
Message-ID: <7c992ec1-3cef-7a08-2a45-1142798b6af4@intel.com> (raw)
In-Reply-To: <20180329164021.51728-1-ajit.khaparde@broadcom.com>
On 3/29/2018 5:40 PM, Ajit Khaparde wrote:
> From: Scott Branden <scott.branden@broadcom.com>
>
> Update the license header on bnxt files to be the standard
> BSD-3-Clause license used for the rest of DPDK,
> bring the files in compliance with the DPDK licensing policy.
>
> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Cc:hemant.agrawal@nxp.com
> ----
> v1->v2: modify first line of SPDX identifer as per review comment.
> ---
> doc/guides/nics/bnxt.rst | 30 ++----------------------------
> drivers/net/bnxt/bnxt.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_cpr.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_cpr.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_ethdev.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_filter.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_filter.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_hwrm.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_hwrm.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_irq.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_irq.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_nvm_defs.h | 11 +++--------
> drivers/net/bnxt/bnxt_ring.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_ring.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_rxq.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_rxq.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_rxr.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_rxr.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_stats.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_stats.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_txq.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_txq.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_txr.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_txr.h | 32 ++------------------------------
> drivers/net/bnxt/bnxt_vnic.c | 32 ++------------------------------
> drivers/net/bnxt/bnxt_vnic.h | 32 ++------------------------------
> drivers/net/bnxt/hsi_struct_def_dpdk.h | 32 ++------------------------------
> drivers/net/bnxt/rte_pmd_bnxt.c | 32 ++------------------------------
> drivers/net/bnxt/rte_pmd_bnxt.h | 32 ++------------------------------
> 29 files changed, 59 insertions(+), 846 deletions(-)
Can you please update Makefile too, but I can see it has multiple coypright, it
can be better to send it as a separate patch to not block this one.
<...>
> @@ -1,34 +1,6 @@
> -/*-
> - * BSD LICENSE
> - *
> - * Copyright(c) Broadcom Limited.
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2014-2018 Broadcom
> * All rights reserved.
It might be nit-picking but we don't have leading spaces [1] in format, are they
intentional?
If not it is easy to fix when introduced otherwise will stay as it is forever J
[1]
/* SPDX-License-Identifier: BSD-3-Clause
* Copyright(c) 2014-2018 Broadcom
* All rights reserved.
*/
<...>
next prev parent reply other threads:[~2018-03-30 10:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 19:07 [dpdk-dev] [PATCH] " Ajit Khaparde
2018-03-26 7:28 ` Hemant Agrawal
[not found] ` <3f4ea1f2-023e-46f8-96e2-e7380ed5f3c2@broadcom.com>
2018-03-27 6:51 ` Hemant Agrawal
2018-03-29 16:40 ` [dpdk-dev] [PATCH v2] " Ajit Khaparde
2018-03-30 10:35 ` Ferruh Yigit [this message]
2018-03-30 18:10 ` Scott Branden
2018-03-31 21:08 ` Ferruh Yigit
2018-04-02 18:57 ` Scott Branden
2018-04-02 22:34 ` [dpdk-dev] [PATCH v3] " Ajit Khaparde
2018-04-03 6:29 ` Hemant Agrawal
2018-04-05 14:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c992ec1-3cef-7a08-2a45-1142798b6af4@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).