From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com
Subject: Re: [PATCH v3 2/4] baseband/fpga_5gnr_fec: add Vista Creek variant
Date: Tue, 17 Oct 2023 14:55:42 +0200 [thread overview]
Message-ID: <7d43e9eb-0a60-4992-808e-43d540cc1efe@redhat.com> (raw)
In-Reply-To: <20230918163114.276722-3-hernan.vargas@intel.com>
On 9/18/23 18:31, Hernan Vargas wrote:
> Create a new file vc_5gnr_pmd.h to store structures and macros specific
> to Vista Creek 5G FPGA implementation and rename functions specific to
> the Vista Creek variant.
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> .../baseband/fpga_5gnr_fec/fpga_5gnr_fec.h | 183 +-----
> .../fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 531 +++++++++---------
> drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h | 140 +++++
> 3 files changed, 426 insertions(+), 428 deletions(-)
> create mode 100644 drivers/baseband/fpga_5gnr_fec/vc_5gnr_pmd.h
>
Overall looks good, but I'll wait for the reworks I asked in patch 3 to
give my R-by.
Thanks,
Maxime
next prev parent reply other threads:[~2023-10-17 12:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 16:31 [PATCH v3 0/4] changes for 23.11 Hernan Vargas
2023-09-18 16:31 ` [PATCH v3 1/4] baseband/fpga_5gnr_fec: renaming for consistency Hernan Vargas
2023-09-18 16:31 ` [PATCH v3 2/4] baseband/fpga_5gnr_fec: add Vista Creek variant Hernan Vargas
2023-10-17 12:55 ` Maxime Coquelin [this message]
2023-09-18 16:31 ` [PATCH v3 3/4] baseband/fpga_5gnr_fec: add AGX100 support Hernan Vargas
2023-10-17 12:48 ` Maxime Coquelin
2023-09-18 16:31 ` [PATCH v3 4/4] baseband/fpga_5gnr_fec: cosmetic comment changes Hernan Vargas
2023-10-17 12:50 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d43e9eb-0a60-4992-808e-43d540cc1efe@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).