From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Junjie Chen <junjie.j.chen@intel.com>,
yliu@fridaylinux.org, xiao.w.wang@intel.com, tiwei.bie@intel.com,
lei.a.yao@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7] vhost: support virtqueue interrupt/notification suppression
Date: Tue, 9 Jan 2018 09:56:54 +0100 [thread overview]
Message-ID: <7de135de-b830-23d7-a725-729b814137a7@redhat.com> (raw)
In-Reply-To: <1515495828-190409-1-git-send-email-junjie.j.chen@intel.com>
On 01/09/2018 12:03 PM, Junjie Chen wrote:
> The driver can suppress interrupt when VIRTIO_F_EVENT_IDX feature bit is
> negotiated. The driver set vring flags to 0, and MAY use used_event in
> available ring to advise device interrupt util reach an index specified
> by used_event. The device ignore the lower bit of vring flags, and send
> an interrupt when index reach used_event.
>
> The device can suppress notification in a manner analogous to the ways
> driver suppress interrupt. The device manipulates flags or avail_event in
> the used ring in the same way the driver manipulates flags or used_event in
> available ring.
>
> Signed-off-by: Junjie Chen<junjie.j.chen@intel.com>
> ---
> v7:
> Add vhost_need_event definition and update code for next virtio.
>
> v6:
> Use volatile qualifier to access avail event idx.
>
> v5:
> Remove updating avail event index in backend.
>
> v2-v4:
> Use definition of VIRTIO_F_EVENT_IDX from kernel.
>
> lib/librte_vhost/vhost.c | 2 +-
> lib/librte_vhost/vhost.h | 44 ++++++++++++++++++++++++++++++++++++++-----
> lib/librte_vhost/virtio_net.c | 6 +++---
> 3 files changed, 43 insertions(+), 9 deletions(-)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
prev parent reply other threads:[~2018-01-09 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 11:02 [dpdk-dev] [PATCH v4] " junjie.j.chen
2017-12-23 16:55 ` [dpdk-dev] [PATCH v5] " Junjie Chen
2017-12-26 8:03 ` Wang, Xiao W
2017-12-26 17:43 ` [dpdk-dev] [PATCH v6] " Junjie Chen
2018-01-05 5:25 ` Wang, Xiao W
2018-01-08 14:06 ` Yuanhan Liu
2018-01-09 2:12 ` Chen, Junjie J
2018-01-09 2:29 ` Yuanhan Liu
2018-01-09 11:03 ` [dpdk-dev] [PATCH v7] " Junjie Chen
2018-01-09 7:34 ` Yao, Lei A
2018-01-09 12:58 ` Yuanhan Liu
2018-01-09 8:56 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7de135de-b830-23d7-a725-729b814137a7@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=junjie.j.chen@intel.com \
--cc=lei.a.yao@intel.com \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).