From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, yliu@fridaylinux.org, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/5] net/virtio: remove redundant macro definitions for vector Rx
Date: Thu, 7 Dec 2017 10:18:14 +0100 [thread overview]
Message-ID: <7de90139-bf6f-24e8-9ab5-c1c666f28ccb@redhat.com> (raw)
In-Reply-To: <20171207053059.19487-5-tiwei.bie@intel.com>
On 12/07/2017 06:30 AM, Tiwei Bie wrote:
> RTE_VIRTIO_VPMD_RX_BURST and RTE_VIRTIO_VPMD_RX_REARM_THRESH
> have been defined and used in virtio_rxtx_simple.h, but are
> defined agained in virtio_rxtx_simple_*.c. It just happens to
s/agained/again/
> work. So remove the redundant definitions from the *.c files.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> drivers/net/virtio/virtio_rxtx_simple_neon.c | 2 --
> drivers/net/virtio/virtio_rxtx_simple_sse.c | 2 --
> 2 files changed, 4 deletions(-)
Apart from above typo:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2017-12-07 9:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 5:30 [dpdk-dev] [PATCH 0/5] various fixes and cleanups for virtio PMD Tiwei Bie
2017-12-07 5:30 ` [dpdk-dev] [PATCH 1/5] net/virtio: fix vector Rx break caused by rxq flushing Tiwei Bie
2017-12-07 9:14 ` Maxime Coquelin
2017-12-07 9:30 ` Fischetti, Antonio
2017-12-07 18:10 ` Fischetti, Antonio
2017-12-07 16:00 ` Kevin Traynor
2017-12-08 2:30 ` Tiwei Bie
2017-12-08 10:17 ` Kevin Traynor
2017-12-07 5:30 ` [dpdk-dev] [PATCH 2/5] net/virtio: fix typo in LRO support Tiwei Bie
2017-12-07 9:15 ` Maxime Coquelin
2017-12-07 5:30 ` [dpdk-dev] [PATCH 3/5] net/virtio: remove a redundant macro definition for ctrl vq Tiwei Bie
2017-12-07 9:16 ` Maxime Coquelin
2017-12-07 5:30 ` [dpdk-dev] [PATCH 4/5] net/virtio: remove redundant macro definitions for vector Rx Tiwei Bie
2017-12-07 9:18 ` Maxime Coquelin [this message]
2017-12-07 10:39 ` Tiwei Bie
2017-12-07 5:30 ` [dpdk-dev] [PATCH 5/5] net/virtio: squeeze repeated blank lines Tiwei Bie
2017-12-07 9:22 ` Maxime Coquelin
2017-12-07 10:32 ` Tiwei Bie
2017-12-11 5:13 ` [dpdk-dev] [PATCH v2 0/4] various fixes and cleanups for virtio PMD Tiwei Bie
2017-12-11 5:13 ` [dpdk-dev] [PATCH v2 1/4] net/virtio: fix vector Rx break caused by rxq flushing Tiwei Bie
2017-12-11 5:13 ` [dpdk-dev] [PATCH v2 2/4] net/virtio: fix typo in LRO support Tiwei Bie
2017-12-11 5:13 ` [dpdk-dev] [PATCH v2 3/4] net/virtio: remove a redundant macro definition for ctrl vq Tiwei Bie
2017-12-11 5:13 ` [dpdk-dev] [PATCH v2 4/4] net/virtio: remove redundant macro definitions for vector Rx Tiwei Bie
2017-12-27 14:46 ` [dpdk-dev] [PATCH v2 0/4] various fixes and cleanups for virtio PMD Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7de90139-bf6f-24e8-9ab5-c1c666f28ccb@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).