From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Chas Williams <chas3@att.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption
Date: Fri, 12 Apr 2019 17:28:17 +0100 [thread overview]
Message-ID: <7e03b000-f4d4-71c3-5978-8a8623d7ace5@intel.com> (raw)
In-Reply-To: <20190408164112.12471-1-stephen@networkplumber.org>
On 4/8/2019 5:41 PM, Stephen Hemminger wrote:
> If the af_packet transmit is sending a VLAN packet,
> and the transmit path to the kernel os full, then it would
> mismanage the outgoing mbuf. The original mbuf would end up
> being freed twice, once by AF_PACKET PMD and once by caller.
This comment is valid with your new patch [1] that updates 'rte_vlan_insert()'
to duplicate the mbuf, right?
That patch looks like won't make the release, so I suggest this one wait that
patch, although this is harmless on its own, commit log is misleading.
[1]
https://patches.dpdk.org/patch/51870/
>
> Reported-by: Chas Williams <3chas3@gmail.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v2 - fix unnecessary parenthesis (was in original code)
>
> drivers/net/af_packet/rte_eth_af_packet.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
> index 99e13fe48a30..91ceb94ecbaa 100644
> --- a/drivers/net/af_packet/rte_eth_af_packet.c
> +++ b/drivers/net/af_packet/rte_eth_af_packet.c
> @@ -200,6 +200,11 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> continue;
> }
>
> + /* point at the next incoming frame */
> + if (ppd->tp_status != TP_STATUS_AVAILABLE &&
> + poll(&pfd, 1, -1) < 0)
> + break;
> +
> /* insert vlan info if necessary */
> if (mbuf->ol_flags & PKT_TX_VLAN_PKT) {
> if (rte_vlan_insert(&mbuf)) {
> @@ -208,11 +213,6 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
> }
> }
>
> - /* point at the next incoming frame */
> - if ((ppd->tp_status != TP_STATUS_AVAILABLE) &&
> - (poll(&pfd, 1, -1) < 0))
> - break;
> -
> /* copy the tx frame data */
> pbuf = (uint8_t *) ppd + TPACKET2_HDRLEN -
> sizeof(struct sockaddr_ll);
>
next prev parent reply other threads:[~2019-04-12 16:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 16:04 [dpdk-dev] [PATCH] " Stephen Hemminger
2019-04-08 16:04 ` Stephen Hemminger
2019-04-08 16:41 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2019-04-08 16:41 ` Stephen Hemminger
2019-04-12 16:28 ` Ferruh Yigit [this message]
2019-04-12 16:28 ` Ferruh Yigit
2019-04-12 22:08 ` Stephen Hemminger
2019-04-12 22:08 ` Stephen Hemminger
2019-04-16 9:37 ` Ferruh Yigit
2019-04-16 9:37 ` Ferruh Yigit
2019-04-16 9:42 ` Bruce Richardson
2019-04-16 9:42 ` Bruce Richardson
2019-04-16 15:03 ` Stephen Hemminger
2019-04-16 15:03 ` Stephen Hemminger
2019-04-16 15:13 ` Bruce Richardson
2019-04-16 15:13 ` Bruce Richardson
2019-07-04 18:43 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e03b000-f4d4-71c3-5978-8a8623d7ace5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).