From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Rushil Gupta <rushilg@google.com>
Cc: qi.z.zhang@intel.com, jingjing.wu@intel.com,
junfeng.guo@intel.com, joshwash@google.com, dev@dpdk.org,
Jeroen de Borst <jeroendb@google.com>
Subject: Re: [PATCH] net/gve: Check whether the driver is compatible with the device presented.
Date: Mon, 8 May 2023 17:00:41 +0100 [thread overview]
Message-ID: <7eb32bfb-7c0e-3073-2e81-eb39f16c26fc@amd.com> (raw)
In-Reply-To: <CANzqiF7ciwYDrmFHzJWgE8k97QE3dyqUsif8XZhHUzO8okXCGQ@mail.gmail.com>
On 5/8/2023 7:23 AM, Rushil Gupta wrote:
>>> +#ifndef _GVE_VERSION_H_
>>> +#define _GVE_VERSION_H_
>>> +
>>> +#include <rte_version.h>
>>> +
>>> +#define GVE_VERSION_PREFIX "DPDK-"
>>> +#define GVE_VERSION_MAJOR 1
>>> +#define GVE_VERSION_MINOR 0
>>> +#define GVE_VERSION_SUB 0
>>> +
>> Is this GVE base version, or DPDK gve version?
>> Previous version information was "GVE-1.3.0", now it is becoming
>> "DPDK-1.0.0",
>> is this breaking the version link with GVE base version and creating a
>> new versioning scheme for DPDK GVE driver?
>>
>> Btw, documentation still has "v1.3.0. GVE base code", should it be
>> updated as well?
>>
> DPDK-1.0.0 is the DPDK driver version. GVE driver versioning only
> applies for linux kernel Gvnic driver.
> Similarly Windows Gvnic driver has different versioning system.
So creating a new versioning scheme for DPDK driver, I guess that is OK.
Since there is a new version, is it clear how to manage the versioning,
like when to update major version and when to update minor etc? If so
can you please document this?
And base code is still coming from the Linux kernel driver, I wonder if
a mapping between versions of these two is required.
As mentioned "v1.3.0" is still in the documentation, what happens if
base code updated and some relevant update is required in the dpdk
driver code? How to record/manage this?
Some drivers records the base code version in a readme file in the base
folder, maybe same can be done.
next prev parent reply other threads:[~2023-05-08 16:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 5:14 Rushil Gupta
2023-04-14 9:05 ` Guo, Junfeng
2023-04-14 15:40 ` Ferruh Yigit
2023-04-18 5:30 ` Guo, Junfeng
2023-04-26 21:37 ` Rushil Gupta
2023-05-04 15:06 ` Ferruh Yigit
2023-05-08 6:23 ` Rushil Gupta
2023-05-08 16:00 ` Ferruh Yigit [this message]
2023-05-08 19:22 ` Rushil Gupta
2023-05-08 19:15 ` [v2] net/gve: check driver compatibility Rushil Gupta
2023-05-17 16:58 ` Ferruh Yigit
2023-05-18 17:41 ` Rushil Gupta
2023-05-19 7:15 ` [v3] " Rushil Gupta
2023-05-19 7:23 ` [PATCH] " Rushil Gupta
2023-05-19 7:26 ` Rushil Gupta
2023-05-19 7:41 ` Rushil Gupta
2023-05-19 10:04 ` Ferruh Yigit
2023-05-19 16:15 ` Rushil Gupta
2023-05-19 19:54 ` [v4] " Rushil Gupta
2023-05-19 20:46 ` Rushil Gupta
2023-05-19 20:56 ` Stephen Hemminger
2023-05-20 16:44 ` Rushil Gupta
2023-05-22 8:52 ` Ferruh Yigit
2023-05-22 15:45 ` Rushil Gupta
2023-05-23 10:20 ` Ferruh Yigit
2023-05-23 10:21 ` Ferruh Yigit
2023-05-24 17:14 ` Rushil Gupta
2023-05-31 16:40 ` Rushil Gupta
2023-05-24 17:13 ` [v5] " Rushil Gupta
2023-05-31 17:04 ` Ferruh Yigit
2023-05-18 17:40 ` [v3] " Rushil Gupta
2023-05-08 19:14 ` [v2] " Rushil Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eb32bfb-7c0e-3073-2e81-eb39f16c26fc@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=jeroendb@google.com \
--cc=jingjing.wu@intel.com \
--cc=joshwash@google.com \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rushilg@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).