From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@caviumnetworks.com>,
santosh.shukla@cavium.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] net/octeontx: add channel to port id mapping
Date: Fri, 8 Dec 2017 09:39:00 -0800 [thread overview]
Message-ID: <7ebbd6b4-e7ea-4ed0-f06d-572fb1cc3957@intel.com> (raw)
In-Reply-To: <20171208110807.wafb4z6q74t7hzht@Pavan-LT>
On 12/8/2017 3:08 AM, Pavan Nikhilesh Bhagavatula wrote:
> On Thu, Dec 07, 2017 at 04:41:04PM -0800, Ferruh Yigit wrote:
>> On 11/28/2017 6:58 AM, Pavan Nikhilesh wrote:
>>> The channel to port id map is used by event octeontx to map the received
>>> wqe to the respective ethdev port.
>>>
>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
>>
>> <...>
>>
>>> @@ -52,12 +52,18 @@
>>> #define OCTEONTX_VDEV_NR_PORT_ARG ("nr_port")
>>> #define OCTEONTX_MAX_NAME_LEN 32
>>>
>>> +#define OCTEONTX_MAX_BGX_PORTS 4
>>> +#define OCTEONTX_MAX_LMAC_PER_BGX 4
>>> +
>>> static inline struct octeontx_nic *
>>> octeontx_pmd_priv(struct rte_eth_dev *dev)
>>> {
>>> return dev->data->dev_private;
>>> }
>>>
>>> +uint16_t __rte_cache_aligned
>>> +octeontx_pchan_map[OCTEONTX_MAX_BGX_PORTS][OCTEONTX_MAX_LMAC_PER_BGX];
>>
>> defining global variable in header is generally not good a idea, is there a
>> reason why not variable defined in octeontx_ethdev.c and exported here, so that
>> both octeontx ethdev and eventdev can use it?
>
> The reason extern definition in .h and declaration in .c is not done is that
> it would break shared compilation.
This should work, you can put object into .so and access from application and/or
other shared libraries. I did a quick test, and seems working, is there anything
I am missing.
> The other approach is to do it in octeontx_mempool area but it wouldnt make
> sense.
> I could use the mempool approach if it sounds good to you (or) let me know
> if any alternate approach comes to your mind.
>
>>
>> btw, is build time dependency between octeontx ethdev and eventdev documented
>> somewhere?
>
> Currently, there is no build time dependency between event_octeontx and
> eth_octeontx i.e everything builds fine with CONFIG_RTE_LIBRTE_OCTEONTX_PMD=n.
octeontx eventdev is using a variable from octeontx ethdev header, how can be
there is no build time dependency?
>
> Thanks,
> Pavan
>
next prev parent reply other threads:[~2017-12-08 17:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 14:58 Pavan Nikhilesh
2017-11-28 14:58 ` [dpdk-dev] [PATCH 2/2] event/octeontx: fix Rx adapter " Pavan Nikhilesh
2017-12-08 0:41 ` [dpdk-dev] [PATCH 1/2] net/octeontx: add channel to " Ferruh Yigit
2017-12-08 11:08 ` Pavan Nikhilesh Bhagavatula
2017-12-08 17:39 ` Ferruh Yigit [this message]
2017-12-09 9:25 ` Pavan Nikhilesh Bhagavatula
2017-12-09 12:55 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2017-12-09 12:55 ` [dpdk-dev] [PATCH v2 2/2] event/octeontx: fix Rx adapter " Pavan Nikhilesh
2017-12-18 9:43 ` santosh
2017-12-18 9:41 ` [dpdk-dev] [PATCH v2 1/2] net/octeontx: add channel to " santosh
2017-12-18 21:52 ` Pavan Nikhilesh
2017-12-19 18:01 ` [dpdk-dev] [PATCH v3 " Pavan Nikhilesh
2017-12-19 18:01 ` [dpdk-dev] [PATCH v3 2/2] event/octeontx: fix Rx adapter " Pavan Nikhilesh
2018-01-09 12:47 ` [dpdk-dev] [PATCH v3 1/2] net/octeontx: add channel to " Ferruh Yigit
2018-01-09 12:49 ` Ferruh Yigit
2018-01-10 7:59 ` Pavan Nikhilesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ebbd6b4-e7ea-4ed0-f06d-572fb1cc3957@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=pbhagavatula@caviumnetworks.com \
--cc=santosh.shukla@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).