From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
David Christensen <drc@linux.vnet.ibm.com>
Cc: dev@dpdk.org, Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <gakhil@marvell.com>
Subject: Re: [PATCH] net/tap: Set locally administered bit with a fixed MAC address
Date: Wed, 26 Apr 2023 16:58:14 +0100 [thread overview]
Message-ID: <7f6d9fb8-c36c-4e36-b7a6-6a4e31007ef1@amd.com> (raw)
In-Reply-To: <20230425173959.3cb70f20@hermes.local>
On 4/26/2023 1:39 AM, Stephen Hemminger wrote:
> On Tue, 25 Apr 2023 16:58:06 -0400
> David Christensen <drc@linux.vnet.ibm.com> wrote:
>
>> When the tap driver is loaded and the user selects the optional
>> "mac=fixed" setting, the tap driver incorrectly uses a globally
>> unique EUI-48 identifier (as documented in RFC 7042) of
>> 00:64:74:61:70:<iface_idx>. Since this is a locally generated ID,
>> the Local bit in the MAC address should be set to 1, resulting in
>> the new address 02:64:74:61:70:<iface_idx>.
>>
>> Bugzilla ID: 1198
>>
>> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
Bugzilla ID: 1198
Fixes: f6921783fee6 ("net/tap: add support for fixed MAC addresses")
Cc: stable@dpdk.org
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
Dropped 'examples/ipsec-secgw/test/common_defs.sh' change while merging,
although it is a minor change can you please send a separate patch for it?
prev parent reply other threads:[~2023-04-26 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 20:58 David Christensen
2023-04-26 0:39 ` Stephen Hemminger
2023-04-26 15:58 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f6d9fb8-c36c-4e36-b7a6-6a4e31007ef1@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=gakhil@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).