From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kvargs: fix building with meson outside source tree
Date: Thu, 19 Jul 2018 15:45:01 +0100 [thread overview]
Message-ID: <7f7269e5-e439-6655-4fe8-7c0e9166f35d@intel.com> (raw)
In-Reply-To: <20180719142648.44824-1-bruce.richardson@intel.com>
On 19-Jul-18 3:26 PM, Bruce Richardson wrote:
> When building DPDK with meson with the <builddir> being outside the source
> directory, an error was generated as the path to the EAL headers was not
> found. The path specified for the includes backed out unnecessarily far and
> so broke when the build directory was not in the expected location of
> just inside the source dir. Changing the path to be shorter, just going
> down one level and then into EAL builds for both cases - where builddir is
> in source directory, and also when it's outside it.
>
> Fixes: 092ee516496d ("kvargs: build before EAL")
>
> Reported-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> lib/librte_kvargs/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_kvargs/meson.build b/lib/librte_kvargs/meson.build
> index a1c724961..acd3e5432 100644
> --- a/lib/librte_kvargs/meson.build
> +++ b/lib/librte_kvargs/meson.build
> @@ -2,7 +2,7 @@
> # Copyright(c) 2017 Intel Corporation
>
> includes = [global_inc]
> -includes += include_directories('../../../lib/librte_eal/common/include')
> +includes += include_directories('../librte_eal/common/include')
>
> version = 1
> sources = files('rte_kvargs.c')
>
Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-07-19 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 14:26 Bruce Richardson
2018-07-19 14:45 ` Burakov, Anatoly [this message]
2018-07-26 8:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f7269e5-e439-6655-4fe8-7c0e9166f35d@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).