From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Igor Ryzhov <iryzhov@nfware.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: use kni_ethtool_ops only with unknown drivers
Date: Mon, 3 Dec 2018 13:09:29 +0000 [thread overview]
Message-ID: <7f929055-b55a-e839-9927-96787db88094@intel.com> (raw)
In-Reply-To: <20181130153815.3be2f30b@xeon-e3>
On 11/30/2018 11:38 PM, Stephen Hemminger wrote:
> On Fri, 30 Nov 2018 22:47:50 +0300
> Igor Ryzhov <iryzhov@nfware.com> wrote:
>
>> Current implementation of kni_ethtool_ops just uses corresponding
>> ethtool_ops function of underlying driver for all functions except for
>> .get_link. This commit sets kni->net_dev->ethtool_ops directly to the
>> ethtool_ops of the corresponding driver.
>>
>> For unknown drivers (all but ixgbe and i40e) we still use
>> kni_ethtool_ops with implemented .get_link function.
>>
>> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
>
> Why does KNI still support ethtool which:
> 1. Only works on a subset of devices
> 2. Requires a 3rd implmentation of the HW device (Linux, DPDK, and KNI)
+1 to drop ethtool support, last time we tried concern was anybody may be using
it, perhaps we can try again.
>
> Then again why does KNI exist at all? What is missing from virtio user which
> is faster anyway.
>
next prev parent reply other threads:[~2018-12-03 13:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 19:29 [dpdk-dev] [PATCH] " Igor Ryzhov
2018-11-30 19:47 ` [dpdk-dev] [PATCH v2] " Igor Ryzhov
2018-11-30 23:38 ` Stephen Hemminger
2018-12-01 11:12 ` Igor Ryzhov
2018-12-01 17:31 ` Stephen Hemminger
2018-12-02 10:54 ` Igor Ryzhov
2018-12-03 19:51 ` Stephen Hemminger
2018-12-18 18:10 ` Ferruh Yigit
2018-12-03 13:09 ` Ferruh Yigit [this message]
2018-12-03 14:06 ` Igor Ryzhov
2018-12-18 18:13 ` Ferruh Yigit
2019-01-05 16:53 ` Igor Ryzhov
2018-12-18 18:04 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f929055-b55a-e839-9927-96787db88094@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).