From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Nikolay Nikolaev <nicknickolaev@gmail.com>,
maxime.coquelin@redhat.com, tiwei.bie@intel.com,
zhihong.wang@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/5] vhost: unify VhostUserMsg usage
Date: Thu, 20 Sep 2018 16:56:15 +0100 [thread overview]
Message-ID: <7fe10407-c03a-1899-d4cc-d4f27833d317@intel.com> (raw)
In-Reply-To: <153698882681.23049.10483393218056672951.stgit@T460>
On 15-Sep-18 6:20 AM, Nikolay Nikolaev wrote:
> Use the typedef version of struct VhostUserMsg. Also unify the related
> parameter name.
>
> Signed-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>
> ---
I'm probably missing some background on this, but according to DPDK
coding style guide, typedef structs are to be avoided [1].
[1]
https://doc.dpdk.org/guides-18.08/contributing/coding_style.html#typedefs
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-09-20 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 5:20 [dpdk-dev] [PATCH v3 0/5] vhost: vhost_user.c code cleanup Nikolay Nikolaev
2018-09-15 5:20 ` [dpdk-dev] [PATCH v3 1/5] vhost: unify VhostUserMsg usage Nikolay Nikolaev
2018-09-20 15:56 ` Burakov, Anatoly [this message]
2018-09-15 5:20 ` [dpdk-dev] [PATCH v3 2/5] vhost: make message handling functions prepare the reply Nikolay Nikolaev
2018-09-15 5:20 ` [dpdk-dev] [PATCH v3 3/5] vhost: handle unsupported message types in functions Nikolay Nikolaev
2018-09-15 5:20 ` [dpdk-dev] [PATCH v3 4/5] vhost: unify message handling function signature Nikolay Nikolaev
2018-09-15 5:20 ` [dpdk-dev] [PATCH v3 5/5] vhost: message handling implemented as a callback array Nikolay Nikolaev
2018-09-19 7:37 ` Maxime Coquelin
2018-09-20 6:34 ` Nikolay Nikolaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fe10407-c03a-1899-d4cc-d4f27833d317@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).