From: Andrew Rybchenko <arybchenko@solarflare.com>
To: <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/3] net/sfc: fix power of 2 alignment macros
Date: Wed, 24 Jul 2019 16:04:24 +0300 [thread overview]
Message-ID: <81075521-b15c-55ca-5804-5f1c52dc3820@solarflare.com> (raw)
In-Reply-To: <1563973146-16577-1-git-send-email-arybchenko@solarflare.com>
On 7/24/19 3:59 PM, Andrew Rybchenko wrote:
> P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller
> than type of the value to be aligned.
>
> IS_P2ALIGNED() has no the problem since it cast its arugments
> to uintptr_t inside, but fixed anyway to follow the same approach as
> new EFX_P2ROUNDUP() and EFX_P2ALIGN().
>
> Patches have checkpatches.sh warnings in base driver since space
> is required after sizeof.
>
> Andrew Rybchenko (3):
> net/sfc: fix power of 2 round up when align has smaller type
> net/sfc: fix align to power of 2 when align has smaller type
> net/sfc: unify power of 2 alignment check macro
>
> drivers/net/sfc/base/ef10_impl.h | 9 +++---
> drivers/net/sfc/base/ef10_nvram.c | 3 +-
> drivers/net/sfc/base/ef10_rx.c | 11 ++++---
> drivers/net/sfc/base/efx.h | 21 ++++++++++---
> drivers/net/sfc/base/efx_mcdi.h | 9 ++++--
> drivers/net/sfc/base/efx_tx.c | 4 +--
> drivers/net/sfc/efsys.h | 51 +++++++++++++++----------------
> drivers/net/sfc/sfc_ethdev.c | 2 +-
> drivers/net/sfc/sfc_rx.c | 2 +-
> 9 files changed, 64 insertions(+), 48 deletions(-)
>
Self NACK since the second patch fixes the first one. I'll send v2 shortly.
next prev parent reply other threads:[~2019-07-24 13:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 12:59 Andrew Rybchenko
2019-07-24 12:59 ` [dpdk-dev] [PATCH 1/3] net/sfc: fix power of 2 round up when align has smaller type Andrew Rybchenko
2019-07-24 12:59 ` [dpdk-dev] [PATCH 2/3] net/sfc: fix align to power of 2 " Andrew Rybchenko
2019-07-24 12:59 ` [dpdk-dev] [PATCH 3/3] net/sfc: unify power of 2 alignment check macro Andrew Rybchenko
2019-07-24 13:04 ` Andrew Rybchenko [this message]
2019-07-24 13:08 ` [dpdk-dev] [PATCH v2 0/3] net/sfc: fix power of 2 alignment macros Andrew Rybchenko
2019-07-24 13:08 ` [dpdk-dev] [PATCH v2 1/3] net/sfc: fix power of 2 round up when align has smaller type Andrew Rybchenko
2019-07-24 13:08 ` [dpdk-dev] [PATCH v2 3/3] net/sfc: unify power of 2 alignment check macro Andrew Rybchenko
2019-07-24 13:16 ` [dpdk-dev] [PATCH v3 0/3] net/sfc: fix power of 2 alignment macros Andrew Rybchenko
2019-07-24 13:16 ` [dpdk-dev] [PATCH v3 1/3] net/sfc: fix power of 2 round up when align has smaller type Andrew Rybchenko
2019-07-24 16:57 ` Ferruh Yigit
2019-07-24 18:41 ` Andrew Rybchenko
2019-07-24 18:52 ` Ferruh Yigit
2019-07-24 13:16 ` [dpdk-dev] [PATCH v3 2/3] net/sfc: fix align to power of 2 " Andrew Rybchenko
2019-07-24 13:16 ` [dpdk-dev] [PATCH v3 3/3] net/sfc: unify power of 2 alignment check macro Andrew Rybchenko
2019-07-24 18:47 ` [dpdk-dev] [PATCH v3 0/3] net/sfc: fix power of 2 alignment macros Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81075521-b15c-55ca-5804-5f1c52dc3820@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).