From: Ilya Maximets <i.maximets@samsung.com>
To: dev@dpdk.org, Gellert Babel <gellert.babel@ericsson.com>
Cc: Jan Wickbom <jan.wickbom@ericsson.com>,
Jan Wickbom <jan.wickbom@ericsson.com>,
"Tan, Jianfeng" <jianfeng.tan@intel.com>,
Yuanhan Liu <yliu@fridaylinux.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] vhost user: unlink sockaddr when poll sched fails
Date: Mon, 20 Nov 2017 16:07:06 +0300 [thread overview]
Message-ID: <8180d5a9-cf2a-09ad-9a9a-6b1e5bac8007@samsung.com> (raw)
In-Reply-To: <1511161153-5127-1-git-send-email-gellert.babel@ericsson.com>
Hi everyone,
This issue is already discussed many times here and in OVS mail-lists.
The basic restart issue was resolved by removing the sockets at exit
in OVS. The crash scenario is not handled but you're able to remove
all of the left files by some external script before restarting the OVS.
That is one of the discussions about:
http://dpdk.org/ml/archives/dev/2015-December/030326.html
The second point is that vhostuser ports are dpricated now in OVS and
will be removed in future release. So, it's better for you to migrate to
vhostuserclient and everything will be fine because QEMU properly handles
sockets itself.
So, IMHO, we should not add such overkill and, potentially, very dangerous
solutions to DPDK just to fix minor issue in deprecated OVS code.
Best regards, Ilya Maximets.
> From: Jan Wickbom <jan.wickbom at ericsson.com>
>
> Issue:
>
> Vhost user socket addresses left in /var/run/openvswitch.
> This will lead to failure to add vhost user ports with names that
> already exist in this directory.
>
> When there is a failure to add a vhost user socket file descriptor to
> the file descriptor set using fdset_add() in
> rte_vhost_driver_register() the address bound to the socket is not
> released.
>
> Solution:
> Add unlink of the file path corresponding to the socket address.
>
> Signed-off-by: Jan Wickbom <jan.wickbom at ericsson.com>
> Signed-off-by: Gellert Babel <gellert.babel at ericsson.com>
> ---
> lib/librte_vhost/socket.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index 41aa3f9..eb9dae2 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -352,6 +352,7 @@ struct vhost_user {
>
> err:
> close(fd);
> + unlink(path);
> return -1;
> }
>
> --
> 1.9.1
prev parent reply other threads:[~2017-11-20 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 6:59 Gellert Babel
2017-11-20 9:18 ` Tan, Jianfeng
[not found] ` <CGME20171120130713eucas1p21960847cb6dd2927200d623d4fcf27b8@eucas1p2.samsung.com>
2017-11-20 13:07 ` Ilya Maximets [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8180d5a9-cf2a-09ad-9a9a-6b1e5bac8007@samsung.com \
--to=i.maximets@samsung.com \
--cc=dev@dpdk.org \
--cc=gellert.babel@ericsson.com \
--cc=jan.wickbom@ericsson.com \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).