DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: DPDK <dev@dpdk.org>, Ophir Munk <ophirmu@mellanox.com>,
	Pascal Mazon <pascal.mazon@6wind.com>,
	Olga Shern <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file
Date: Tue, 12 Jun 2018 12:36:20 +0000	[thread overview]
Message-ID: <81903AA5-6353-44CE-A8AB-B4B387BC036B@intel.com> (raw)
In-Reply-To: <3421596.l5OksTDFGx@xps>



> On Jun 12, 2018, at 7:26 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> 11/06/2018 18:35, Wiles, Keith:
>> 
>>> On Jun 11, 2018, at 11:06 AM, Ophir Munk <ophirmu@mellanox.com> wrote:
>>> 
>>> This commit explains how to manually compile the C source file
>>> tap_bpf_program.c into an ELF file using the clang compiler.
>>> The code in tap_bpf_program.c requires definitions found in iproute2
>>> source code. This commit suggests cloning the iproute2 git tree and
>>> include its path in the clang command. It also adds inclusion of file
>>> bpf_api.h (required for eBPF definitions) which is located in iproute2
>>> source tree. For more details refer to TAP documentation.
>>> This commit is related to commits [1] and [2].
>> 
>> Normally I would have suggested that eBPF be disable in the TAP driver as it requires external code and programs, but that ship has sailed.
> 
> The external programs are required only to generate new instructions,
> changing the behaviour of the BPF program.
> Currently, the instructions for RSS behaviour are provided.
> 
>> I would like to see building the tap_bpf_program.o as a target in the Makefile, this way the developer can just run the ‘make bpf_program’ target and it would be simpler and less error prone.
> 
> For this to happen, we need to improve the tools.

In what way do we need to improve the tools and which tools are we talking about. Building the .o file below appears to be a simple set of command lines. I have a question in my original email about what tool.

> It is a work in progress.
> This is a very first step to use Linux BPF with DPDK.
> If there are more interests, we should really streamline its usage
> for all parts of DPDK which runs on top of some kernel code.

streamlining other parts of DPDK would be nice, but we are now talking about the tap/eBPF patch.

> 
> 
> 

Regards,
Keith


  reply	other threads:[~2018-06-12 12:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 16:06 Ophir Munk
     [not found] ` <A1755B7A-CDB5-4A55-9B44-9C9DEFDA9C88@intel.com>
2018-06-12 12:26   ` Thomas Monjalon
2018-06-12 12:36     ` Wiles, Keith [this message]
2018-06-12 12:58       ` Thomas Monjalon
2018-06-12 13:33         ` Wiles, Keith
2018-06-12 13:44           ` Thomas Monjalon
2018-06-12 13:52             ` Wiles, Keith
2018-06-12 14:02               ` Ophir Munk
2018-07-04 19:47                 ` Ferruh Yigit
2018-07-04 20:11                   ` Thomas Monjalon
2018-07-05 12:34                     ` Wiles, Keith
2018-08-23 12:09                       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81903AA5-6353-44CE-A8AB-B4B387BC036B@intel.com \
    --to=keith.wiles@intel.com \
    --cc=dev@dpdk.org \
    --cc=olgas@mellanox.com \
    --cc=ophirmu@mellanox.com \
    --cc=pascal.mazon@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).