From: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
To: "stephen@networkplumber.org" <stephen@networkplumber.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [EXT] Re: [dpdk-dev] [PATCH] ethdev: fix DMA zone reserve not honoring size
Date: Tue, 2 Apr 2019 00:47:49 +0000 [thread overview]
Message-ID: <819b2c86516855fda65403a8e94be9d03c4d7eeb.camel@marvell.com> (raw)
In-Reply-To: <105f221f-0c64-e950-df9a-2c9eaa0991c3@solarflare.com>
On Mon, 2019-04-01 at 10:30 +0300, Andrew Rybchenko wrote:
> External Email
> On 3/31/19 7:25 PM, Pavan Nikhilesh Bhagavatula wrote:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > The `rte_eth_dma_zone_reserve()` is generally used to create HW
> > rings.
> > In some scenarios when a driver needs to reconfigure the ring size
> > since the named memzone already exists it returns the previous
> > memzone
> > without checking if a different sized ring is requested.
> >
> > Introduce a check to see if the ring size requested is different
> > from the
> > previously created memzone length.
> >
> > Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> > lib/librte_ethdev/rte_ethdev.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_ethdev/rte_ethdev.c
> > b/lib/librte_ethdev/rte_ethdev.c
> > index 12b66b68c..4ae12e43b 100644
> > --- a/lib/librte_ethdev/rte_ethdev.c
> > +++ b/lib/librte_ethdev/rte_ethdev.c
> > @@ -3604,9 +3604,12 @@ rte_eth_dma_zone_reserve(const struct
> > rte_eth_dev *dev, const char *ring_name,
> > }
> >
> > mz = rte_memzone_lookup(z_name);
> > - if (mz)
> > + if (mz && (mz->len == size))
> > return mz;
> >
> > + if (mz)
> > + rte_memzone_free(mz);
>
> NACK
> I really don't like that API which should reserve does free if
> requested
> size does not match previously allocated.
Why? Is due to API name? If so,
Can we have rte_eth_dma_zone_reservere_with_resize() then ?
or any another name, You would like to have?
> I understand the motivation, but I don't think the solution is
> correct.
What you think it has correct solution then?
Obviously, We can not allocate max ring size in init time.
If the NIC has support for 64K HW ring, We will be wasting too much as
it is per queue.
>
> > +
> > return rte_memzone_reserve_aligned(z_name, size, socket_id,
> > RTE_MEMZONE_IOVA_CONTIG, align);
> > }
>
next prev parent reply other threads:[~2019-04-02 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 16:25 [dpdk-stable] " Pavan Nikhilesh Bhagavatula
2019-04-01 7:30 ` Andrew Rybchenko
2019-04-01 9:28 ` Burakov, Anatoly
2019-04-01 9:40 ` Burakov, Anatoly
2019-04-01 12:12 ` [dpdk-stable] [EXT] " Pavan Nikhilesh Bhagavatula
2019-04-02 0:47 ` Jerin Jacob Kollanukkaran [this message]
2019-04-02 7:36 ` [dpdk-stable] [dpdk-dev] [EXT] " Andrew Rybchenko
2019-04-02 8:25 ` Jerin Jacob Kollanukkaran
2019-04-02 8:44 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=819b2c86516855fda65403a8e94be9d03c4d7eeb.camel@marvell.com \
--to=jerinj@marvell.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).