From: "Kadam, Pallavi" <pallavi.kadam@intel.com>
To: Tal Shnaiderman <talshn@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>
Cc: "ranjit.menon@intel.com" <ranjit.menon@intel.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>,
"Narcisa.Vasile@microsoft.com" <Narcisa.Vasile@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix probing for non-netuio bound devices
Date: Wed, 10 Feb 2021 12:47:40 -0800 [thread overview]
Message-ID: <82108b6e-5042-8801-0e4e-c5f96f693136@intel.com> (raw)
In-Reply-To: <DM6PR12MB39454E580D52DF35F44AAF0FA48D9@DM6PR12MB3945.namprd12.prod.outlook.com>
On 2/9/2021 10:00 PM, Tal Shnaiderman wrote:
>> Subject: [PATCH] bus/pci: fix probing for non-netuio bound devices
>>
>> External email: Use caution opening links or attachments
>>
>>
>> Implement rte_pci_map_device() to distinguish between the devices bound
>> to netuio and NDIS devices.
>> Only return success for the netuio devices.
>>
>> Suggested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
>> ---
>> drivers/bus/pci/windows/pci.c | 15 +++++++--------
>> 1 file changed, 7 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
>> index f66258452..16edaa769 100644
>> --- a/drivers/bus/pci/windows/pci.c
>> +++ b/drivers/bus/pci/windows/pci.c
>> @@ -23,20 +23,19 @@
>> DEFINE_DEVPROPKEY(DEVPKEY_Device_Numa_Node, 0x540b947e, 0x8b40,
>> 0x45bc,
>> * the registry hive for PCI devices.
>> */
>>
>> -/* The functions below are not implemented on Windows,
>> +/* Some of the functions below are not implemented on Windows,
>> * but need to be defined for compilation purposes
>> */
>>
>> /* Map pci device */
>> int
>> -rte_pci_map_device(struct rte_pci_device *dev __rte_unused)
>> +rte_pci_map_device(struct rte_pci_device *dev)
>> {
>> - /* This function is not implemented on Windows.
>> - * We really should short-circuit the call to these functions by
>> - * clearing the RTE_PCI_DRV_NEED_MAPPING flag
>> - * in the rte_pci_driver flags.
>> - */
>> - return 0;
>> + /* Only return success for devices bound to netuio */
> Maybe extend this comment to mention where the mapping is actually done?
Modified the comment in v2.
>
>> + if (dev->kdrv == RTE_PCI_KDRV_NIC_UIO)
>> + return 0;
>> + else
>> + return -EINVAL;
> The function should return -1 here to match the behavior with other OS implementations.
Replaced the return value in v2.
Thanks.
>
>> }
>>
>> /* Unmap pci device */
>> --
>> 2.18.0.windows.1
next prev parent reply other threads:[~2021-02-10 20:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 1:40 Pallavi Kadam
2021-02-10 6:00 ` Tal Shnaiderman
2021-02-10 20:47 ` Kadam, Pallavi [this message]
2021-02-10 20:36 ` [dpdk-dev] [PATCH v2] " Pallavi Kadam
2021-02-11 19:30 ` Tal Shnaiderman
2021-03-16 11:20 ` Thomas Monjalon
2021-03-17 16:41 ` Kadam, Pallavi
2021-03-05 2:04 ` Narcisa Ana Maria Vasile
2021-03-05 2:02 ` [dpdk-dev] [PATCH] " Narcisa Ana Maria Vasile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82108b6e-5042-8801-0e4e-c5f96f693136@intel.com \
--to=pallavi.kadam@intel.com \
--cc=Narcisa.Vasile@microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).